Page MenuHomePhorge

Fix invalid CSS overflow value for .phui-oi-name
ClosedPublic

Authored by aklapper on Mar 24 2025, 14:52.
Tags
None
Referenced Files
F3766885: D25921.1745847790.diff
Sun, Apr 27, 13:43
F3754455: D25921.1745818674.diff
Sun, Apr 27, 05:37
F3751255: D25921.1745808123.diff
Sun, Apr 27, 02:42
F3731135: D25921.1745736199.diff
Sat, Apr 26, 06:43
F3531855: D25921.1744884925.diff
Wed, Apr 16, 10:15
F3531852: D25921.1744884831.diff
Wed, Apr 16, 10:13
F3531505: D25921.1744884238.diff
Wed, Apr 16, 10:03
F3531501: D25921.1744883905.diff
Wed, Apr 16, 09:58

Details

Summary

The W3C CSS validator throws Value Error : overflow normal is not a overflow value : normal.
normal is not a valid value for overflow, as browsers currently cannot parse it they fall back to the default visible, thus change it to visible.
See https://developer.mozilla.org/en-US/docs/Web/CSS/overflow

Test Plan

Paste phui-oi-list-view.css into https://jigsaw.w3.org/css-validator/ and read some CSS docs.

Also, visit a page showing a PHUIObjectItemView, like the /phame/post/ page, and
have a object with a veeeeeery long name, and see absolutely no difference A/B,
both on desktop, medium and small screens.

Diff Detail

Repository
rP Phorge
Branch
cssOverflow (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1815
Build 1815: arc lint + arc unit

Event Timeline

Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:

./bin/celerity map

⚙️ Thanks! Bip bop I'm a bot - helping for T15209

This revision is now accepted and ready to land.Mar 28 2025, 10:18