Page MenuHomePhorge

Herald actions: Allow setting subtype on Maniphest tasks
ClosedPublic

Authored by aklapper on Sat, Mar 22, 10:16.
Tags
None
Referenced Files
F3509697: D25913.1744803521.diff
Tue, Apr 15, 11:38
F3480605: D25913.1744767949.diff
Tue, Apr 15, 01:45
F3388489: D25913.1744447135.diff
Fri, Apr 11, 08:38
F3388487: D25913.1744447130.diff
Fri, Apr 11, 08:38
F3388485: D25913.1744447125.diff
Fri, Apr 11, 08:38
F3376633: D25913.1744328208.diff
Wed, Apr 9, 23:36
F3376210: D25913.1744319898.diff
Wed, Apr 9, 21:18
F3373031: D25913.1744258177.diff
Wed, Apr 9, 04:09
Tokens
"Like" token, awarded by 20after4.

Details

Summary

https://secure.phabricator.com/T12314 introduced task subtypes. Allow Herald rules which change/set the subtype of a task.
Code originally written by @20after4 for Wikimedia.

Closes T16022

Test Plan
  1. Have the default subtype configuration with three types under http://phorge.localhost/config/edit/maniphest.subtypes/ defined in src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
  2. Go to http://phorge.localhost/herald/edit/?content_type=HeraldManiphestTaskAdapter&rule_type=global
  3. Under "Action", select the new "Change subtype to" option. Test the subtype search by clicking the magnifier icon, set up a Herald rule to test execution.
  4. Remove the config for http://phorge.localhost/config/edit/maniphest.subtypes/
  5. Repeat step 3, no explosions, default "Task" subtype still exists after removing the config.

Diff Detail

Repository
rP Phorge
Branch
HeraldTaskSubtype (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1788
Build 1788: arc lint + arc unit