Page MenuHomePhorge

Fix implicitly nullable parameter declarations for PHP 8.4
ClosedPublic

Authored by aklapper on Aug 30 2024, 14:40.
Tags
None
Referenced Files
F2977228: D25814.1739625222.diff
Fri, Feb 14, 13:13
F2977227: D25814.1739625221.diff
Fri, Feb 14, 13:13
F2977201: D25814.1739621402.diff
Fri, Feb 14, 12:10
F2977193: D25814.1739620539.diff
Fri, Feb 14, 11:55
F2950686: D25814.1738813346.diff
Wed, Feb 5, 03:42
F2921776: D25814.1737558943.diff
Tue, Jan 21, 15:15
F2874975: D25814.1736968259.diff
Jan 14 2025, 19:10
F2874974: D25814.1736968259.diff
Jan 14 2025, 19:10

Details

Summary

Implicitly nullable parameter declarations are deprecated in PHP 8.4:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

The proposed syntax was introduced in PHP 7.1.

Note: This code change does *not* fix all occurrences but only allows passing ./bin/storage upgrade.

Refs T15935

Test Plan

Try to successfully run ./bin/storage upgrade with PHP 8.4

Diff Detail

Repository
rP Phorge
Branch
T15935php84
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1575
Build 1575: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Oct 18 2024, 12:51