Page MenuHomePhorge

Fix implicitly nullable parameter declarations for PHP 8.4
ClosedPublic

Authored by aklapper on Aug 30 2024, 14:40.

Details

Summary

Implicitly nullable parameter declarations are deprecated in PHP 8.4:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

The proposed syntax was introduced in PHP 7.1.

Note: This code change does *not* fix all occurrences but only allows passing ./bin/storage upgrade.

Refs T15935

Test Plan

Try to successfully run ./bin/storage upgrade with PHP 8.4

Diff Detail

Repository
rP Phorge
Branch
T15935php84
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1575
Build 1575: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Fri, Oct 18, 12:51