Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15750: Integrate CustomField into more interfaces
- Commits
- rP587530a9bf7b: Add Standard Custom Fields to Item List
Set maniphest.custom-field-definitions to the value of P32, and start playing with custom values on tasks.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- custom-list-2
- Lint
Lint Warnings Severity Location Code Message Warning src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:349 TXT3 Line Too Long Advice src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:345 XHP16 TODO Comment Advice src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:349 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 1087 Build 1087: arc lint + arc unit
Event Timeline
Comment Actions
Here's what it looks like with all the bells:
If you're stylistically aligned, I'm sorry for this.
Comment Actions
For some reasons I cannot cleanly apply the patch anymore.
I get:
error: while searching for:
return $indexes;
}
public function renderPropertyViewValue(array $handles) {
$value = $this->getFieldValue();
if (!strlen($value)) {
error: patch failed: src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php:18Comment Actions
Uh! I like this.
| src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php | ||
|---|---|---|
| 376 | I see that the addIcon() also supports a addIcon($value, $label) and it's nice. Maybe useful to somehow expose that label. | |