Add Standard Custom Fields to Item List
Needs ReviewPublic
Actions

Authored by avivey on Mar 1 2024, 16:26.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15750: Integrate CustomField into more interfaces

Summary

Allow "Standard" (config-based") custom fields to be displayed in search-results.

Depends on D25548. Ref T15750.

Test Plan

Set maniphest.custom-field-definitions to the value of P32, and start playing with custom values on tasks.

Diff Detail

Repository

rP Phorge

Branch

custom-list-2

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:349	TXT3	Line Too Long
Advice	src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:345	XHP16	TODO Comment
Advice	src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:349	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 1087
Build 1087: arc lint + arc unit

Event Timeline

avivey created this revision.Mar 1 2024, 16:26

avivey held this revision as a draft.

Owners added a reviewer: O1: Blessed Committers.Mar 1 2024, 16:26

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMar 1 2024, 16:26

Harbormaster completed remote builds in B1087: Diff 1733.Mar 1 2024, 16:26

cleanups

Harbormaster completed remote builds in B1089: Diff 1735.Mar 1 2024, 16:36

avivey edited the summary of this revision. (Show Details)Mar 1 2024, 16:41

avivey edited the test plan for this revision. (Show Details)

avivey added a task: T15750: Integrate CustomField into more interfaces.

lint

Harbormaster completed remote builds in B1090: Diff 1736.Mar 1 2024, 16:45

Here's what it looks like with all the bells:

If you're stylistically aligned, I'm sorry for this.

This is really cool!

20after4 awarded a token.Mar 2 2024, 11:36

aklapper awarded a token.Mar 3 2024, 10:15

avivey mentioned this in Z1: Phorge.Mar 30 2024, 10:44

I'll test this locally, I can't see any reason we shouldn't merge it.

For some reasons I cannot cleanly apply the patch anymore.

I get:

error: while searching for:
    return $indexes;
  }

  public function renderPropertyViewValue(array $handles) {
    $value = $this->getFieldValue();

    if (!strlen($value)) {

error: patch failed: src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php:18

Rebase

Harbormaster completed remote builds in B1249: Diff 1974.Sat, May 11, 10:48