Paths

Table of Contentst

Differential D25440

Show Deprecation Warnings as Setup Warnings
ClosedPublic
Actions

Authored by avivey on Sep 22 2023, 19:41.

Tags

None

Referenced Files

None

Subscribers

valerio.bozzolan

Tokens

"Party Time" token, awarded by revi.

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15554: Handling PHP deprecations: convert to Setup Issues

Commits

rP2ba2cbaf9bbf: Show Deprecation Warnings as Setup Warnings

Summary

Capture Deprecation Warnings, collect them into cache, and show them as a Setup Issue for admins to see and report back to us.

This only captures a sample of the traces, so not to overwhelm users (and RAM. and us) with reports.

Requires D25388. Refs T15554.

Test Plan

Run some flows that are known to bring up Deprecation Warnings. See them as a Setup Issue! Click little triangles to see details.

Diff Detail

Repository

Branch

no-deprect-death

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 957
Build 957: arc lint + arc unit

Event Timeline

avivey created this revision.Sep 22 2023, 19:41

Owners added a reviewer: O1: Blessed Committers.Sep 22 2023, 19:41

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSep 22 2023, 19:41

Harbormaster completed remote builds in B849: Diff 1394.Sep 22 2023, 19:41

avivey requested review of this revision.Sep 22 2023, 19:41

Sten subscribed.Sep 23 2023, 11:14

revi awarded a token.Sep 23 2023, 21:03

revi subscribed.

update some copy

Harbormaster completed remote builds in B950: Diff 1537.Nov 24 2023, 17:46

avivey mentioned this in Z1: Phorge.Nov 24 2023, 18:28

1 comment...

src/applications/system/events/PhorgeSystemDeprecationWarningListener.php
52	Rather than commenting code, we should probably remove it...

This revision is now accepted and ready to land.Nov 26 2023, 06:53

valerio.bozzolan added inline comments.Nov 27 2023, 15:10

src/applications/system/events/PhorgeSystemDeprecationWarningListener.php
41	Note: I think we are sometime doing `null++`, that is elevated to `0++`. It works but probably better to manually assign zero when undefined before accessing it.

rm commented out code

Harbormaster completed remote builds in B957: Diff 1544.Nov 27 2023, 18:16

avivey added inline comments.Nov 27 2023, 18:32

src/applications/system/events/PhorgeSystemDeprecationWarningListener.php
41	In theory, if `$trace_entry` isn't null, it should have a `counter` value, because the only way to add values intro `$cache_entry` is in line 42, where we do initialize `counter`.
52	oops, yeah, shouldn't be here.

add PHP version information to the view.

add PHP version
rebase

This revision is now accepted and ready to land.Dec 8 2023, 15:40

Harbormaster completed remote builds in B979: Diff 1579.Dec 8 2023, 15:41

Closed by commit rP2ba2cbaf9bbf: Show Deprecation Warnings as Setup Warnings. · Explain WhyDec 8 2023, 15:56

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rP2ba2cbaf9bbf: Show Deprecation Warnings as Setup Warnings.

avivey mentioned this in T15737: Include information for installing required PHP version in Diviner docs.Feb 12 2024, 10:14

Revision Contents
Changeset List

Path

Size

Packages

src/

__phutil_library_map__.php

O1: Blessed Committers

applications/

config/

check/

PhorgeCodeWarningSetupCheck.php

79 lines

O1: Blessed Committers

system/

application/

PhabricatorSystemApplication.php

1 line

O1: Blessed Committers

events/

PhorgeSystemDeprecationWarningListener.php

58 lines

O1: Blessed Committers

Diff 1544

src/__phutil_library_map__.php

Loading...

src/applications/config/check/PhorgeCodeWarningSetupCheck.php

Loading...

src/applications/system/application/PhabricatorSystemApplication.php

Loading...

src/applications/system/events/PhorgeSystemDeprecationWarningListener.php

Loading...