Page MenuHomePhorge
Differential D25416

Replacing the deprecated -moz-outline-style with outline-style
ClosedPublic
Actions

Authored by roberto.urbani on Aug 21 2023, 13:18.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15585: Replace or remove deprecated "-moz-outline-style" CSS property
Commits
rP94aefaa31d4c: Replacing the deprecated -moz-outline-style with outline-style
Summary

Replacing the deprecated -moz-outline-style with outline-style: none.

According to "Can I Use", this change is supported in whatever non-ridiculously-old browser web in the universe,
like Firefox 2 and Chrome 4 and Internet Explorer 8.

https://caniuse.com/outline

Ref T15585

Test Plan

The outline in the <a> tags should look as usual, that is, none.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

roberto.urbani created this revision.Aug 21 2023, 13:18
Owners added a reviewer: O1: Blessed Committers.Aug 21 2023, 13:18
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 21 2023, 13:18
Harbormaster completed remote builds in B796: Diff 1319.Aug 21 2023, 13:18
roberto.urbani requested review of this revision.Aug 21 2023, 13:18
roberto.urbani retitled this revision from Task ref: T15585 to Replacing the deprecated -moz-outline-style with outline-style.Aug 21 2023, 14:10
valerio.bozzolan edited the summary of this revision. (Show Details)Aug 24 2023, 18:29
valerio.bozzolan edited the test plan for this revision. (Show Details)
valerio.bozzolan added a task: T15585: Replace or remove deprecated "-moz-outline-style" CSS property.
valerio.bozzolan accepted this revision.Aug 24 2023, 18:33

Tested, seems good to me

To land, please do this from your side:

arc patch D25416
arc land

Thank you!

sgtm

This revision is now accepted and ready to land.Aug 24 2023, 18:33
roberto.urbani added a comment.Aug 25 2023, 08:37
In D25416#11982, @valerio.bozzolan wrote:

Tested, seems good to me

To land, please do this from your side:

arc patch D25416
arc land

Thank you!

When running arc land I get what seems to be a permission issue (?)

fatal: unable to access 'https://we.phorge.it/source/phorge.git/': The requested URL returned error: 403
valerio.bozzolan updated this revision to Diff 1403.Oct 2 2023, 11:47

git rebase master

Harbormaster completed remote builds in B855: Diff 1403.Oct 2 2023, 11:47
valerio.bozzolan added a comment.Oct 13 2023, 08:46

Hoping to be useful, let's land this.

Closed by commit rP94aefaa31d4c: Replacing the deprecated -moz-outline-style with outline-style. · Explain WhyOct 13 2023, 08:47
This revision was automatically updated to reflect the committed changes.
valerio.bozzolan added a commit: rP94aefaa31d4c: Replacing the deprecated -moz-outline-style with outline-style.

Revision Contents
Changeset List

PathSizePackages
resources/
celerity/
O1: Blessed Committers
webroot/
rsrc/
css/
core/
2 linesO1: Blessed Committers

Diff 1417

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/core.css

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0