Page MenuHomePhorge

Replacing the deprecated -moz-outline-style with outline-style
ClosedPublic

Authored by roberto.urbani on Aug 21 2023, 13:18.

Details

Summary

Replacing the deprecated -moz-outline-style with outline-style: none.

According to "Can I Use", this change is supported in whatever non-ridiculously-old browser web in the universe,
like Firefox 2 and Chrome 4 and Internet Explorer 8.

https://caniuse.com/outline

Ref T15585

Test Plan

The outline in the <a> tags should look as usual, that is, none.

Diff Detail

Repository
rP Phorge
Branch
arcpatch-D25416_1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 855
Build 855: arc lint + arc unit

Event Timeline

roberto.urbani retitled this revision from Task ref: T15585 to Replacing the deprecated -moz-outline-style with outline-style.Aug 21 2023, 14:10

Tested, seems good to me

To land, please do this from your side:

arc patch D25416
arc land

Thank you!

sgtm

This revision is now accepted and ready to land.Aug 24 2023, 18:33

Tested, seems good to me

To land, please do this from your side:

arc patch D25416
arc land

Thank you!

When running arc land I get what seems to be a permission issue (?)

fatal: unable to access 'https://we.phorge.it/source/phorge.git/': The requested URL returned error: 403

Hoping to be useful, let's land this.