Page MenuHomePhorge
Differential D25407

Line counters: do not wrap when over 999 on mobile
ClosedPublic
Actions

Authored by valerio.bozzolan on Aug 17 2023, 16:36.
Tags
None
Referenced Files
F4117140: D25407.1746982035.diff
Sat, May 10, 16:47
F4055865: D25407.1746778202.diff
Thu, May 8, 08:10
F4036390: D25407.1746717460.diff
Wed, May 7, 15:17
F4036389: D25407.1746717459.diff
Wed, May 7, 15:17
F3980818: D25407.1746543861.diff
Mon, May 5, 15:04
F3980817: D25407.1746543829.diff
Mon, May 5, 15:03
F3980816: D25407.1746543817.diff
Mon, May 5, 15:03
F3946184: D25407.1746446524.diff
Sun, May 4, 12:02
View All 79 Files
Subscribers
Cigaryno
Matthew
tobiaswiese

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15615: Mobile: Differential lines should not be wrapped
Commits
rP761134a1a9fe: Line counters: do not wrap when over 999 on mobile
Summary
BeforeAfter
Before.png (836×780 px, 131 KB)
After.png (836×780 px, 221 KB)

Closes T15615

Test Plan

Create a very long Diff with soooo much lines (e.g. 1000+).
Reduce the window and check that line numbers do not wrap anymore.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSizePackages
resources/
celerity/
O1: Blessed Committers
webroot/
rsrc/
css/
application/
differential/
1 lineO1: Blessed Committers

Diff 1290

View Options

resources/celerity/map.php

Show First 20 Lines • Show All 407 Lines • ▼ Show 20 Lines if (!empty($monospaced)) {
// break the CSS. Instead, filter it strictly and then mark it as safe. // break the CSS. Instead, filter it strictly and then mark it as safe.
$monospaced = new PhutilSafeHTML( $monospaced = new PhutilSafeHTML(
PhabricatorMonospacedFontSetting::filterMonospacedCSSRule( PhabricatorMonospacedFontSetting::filterMonospacedCSSRule(
$monospaced)); $monospaced));
$font_css = hsprintf( $font_css = hsprintf(
'<style type="text/css">'. '<style type="text/css">'.
'.PhabricatorMonospaced, '. '.PhabricatorMonospaced, '.
'.phabricator-remarkup .remarkup-code-block '. '.phabricator-remarkup .remarkup-code-block .remarkup-code, '.
'.remarkup-code { font: %s !important; } '. '.phabricator-remarkup .remarkup-monospaced '.
'{ font: %s !important; } '.
'</style>', '</style>',
$monospaced); $monospaced);
} }
return hsprintf( return hsprintf(
'%s%s%s%s', '%s%s%s%s',
parent::getHead(), parent::getHead(),
$font_css, $font_css,
▲ Show 20 Lines • Show All 503 Lines • Show Last 20 Lines
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Show First 20 Lines • Show All 407 Lines • ▼ Show 20 Lines if (!empty($monospaced)) {
// break the CSS. Instead, filter it strictly and then mark it as safe. // break the CSS. Instead, filter it strictly and then mark it as safe.
$monospaced = new PhutilSafeHTML( $monospaced = new PhutilSafeHTML(
PhabricatorMonospacedFontSetting::filterMonospacedCSSRule( PhabricatorMonospacedFontSetting::filterMonospacedCSSRule(
$monospaced)); $monospaced));
$font_css = hsprintf( $font_css = hsprintf(
'<style type="text/css">'. '<style type="text/css">'.
'.PhabricatorMonospaced, '. '.PhabricatorMonospaced, '.
'.phabricator-remarkup .remarkup-code-block '. '.phabricator-remarkup .remarkup-code-block .remarkup-code, '.
'.remarkup-code { font: %s !important; } '. '.phabricator-remarkup .remarkup-monospaced '.
'{ font: %s !important; } '.
'</style>', '</style>',
$monospaced); $monospaced);
} }
return hsprintf( return hsprintf(
'%s%s%s%s', '%s%s%s%s',
parent::getHead(), parent::getHead(),
$font_css, $font_css,
▲ Show 20 Lines • Show All 503 Lines • Show Last 20 Lines
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0