Paths

Table of Contentst

Differential D25357

Unify type-checking for `setHref()` type methods
ClosedPublic
Actions

Authored by avivey on Jul 24 2023, 13:23.

Tags

None

Referenced Files

	F3310513: D25357.1743195087.diff
	Thu, Mar 27, 20:51

	F3306617: D25357.1743130138.diff
	Thu, Mar 27, 02:48

	F3304082: D25357.1743091331.diff
	Wed, Mar 26, 16:02

	F3301498: D25357.1743054394.diff
	Wed, Mar 26, 05:46

	F3298491: D25357.1743003635.diff
	Tue, Mar 25, 15:40

	F3295494: D25357.1742955229.diff
	Tue, Mar 25, 02:13

	F3290642: D25357.1742869782.diff
	Mon, Mar 24, 02:29

	F3253168: D25357.1742423030.diff
	Tue, Mar 18, 22:23

View All 27 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15316: PHUITagView and similar: it's unclear whenever 'href' should be just a string

Commits

rPbcfcd9acfc12: Unify type-checking for `setHref()` type methods

Summary

Adopt PhutilURI::checkHrefType() to unify type-check of some PHUI objects.

Ref T15316. Depends on D25356.

Test Plan

In production.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avivey created this revision.Jul 24 2023, 13:23

Owners added a reviewer: O1: Blessed Committers.Jul 24 2023, 13:23

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 24 2023, 13:23

avivey requested review of this revision.Jul 24 2023, 13:23

Harbormaster completed remote builds in B690: Diff 1156.Jul 24 2023, 13:23

avivey retitled this revision from Unify type-checking for `setHref()` type methods to (phorge) Unify type-checking for `setHref()` type methods.Jul 24 2023, 13:25

avivey mentioned this in D25356: (arc) Unify type-checking for `setHref()` type methods.Jul 24 2023, 19:32

avivey mentioned this in rARC6c6f47bf9cf6: (arc) Unify type-checking for `setHref()` type methods.Jul 24 2023, 19:34

valerio.bozzolan added inline comments.Jul 26 2023, 06:56

src/view/phui/PHUITagView.php
106

valerio.bozzolan retitled this revision from (phorge) Unify type-checking for `setHref()` type methods to Unify type-checking for `setHref()` type methods.Jul 26 2023, 06:58

valerio.bozzolan edited the summary of this revision. (Show Details)

+1 with just that inline suggestion

Thanks

This revision is now accepted and ready to land.Aug 2 2023, 16:34

Closed by commit rPbcfcd9acfc12: Unify type-checking for `setHref()` type methods. · Explain WhyAug 12 2023, 15:39

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rPbcfcd9acfc12: Unify type-checking for `setHref()` type methods.

Revision Contents
Changeset List

Path

Size

Packages

src/

view/

phui/

PHUIObjectItemView.php

38 lines

O1: Blessed Committers

PHUITagView.php

13 lines

O1: Blessed Committers

Diff 1244

src/view/phui/PHUIObjectItemView.php

Loading...

src/view/phui/PHUITagView.php

Loading...