Paths

Table of Contentst

Differential D25357

Unify type-checking for `setHref()` type methods
ClosedPublic
Actions

Authored by avivey on Jul 24 2023, 13:23.

Tags

None

Referenced Files

	F2196295: D25357.1716180962.diff
	Sun, May 19, 04:56

	Unknown Object (File)
	Sun, May 12, 22:21

	Unknown Object (File)
	Sat, May 11, 05:45

	Unknown Object (File)
	Fri, May 10, 21:24

	Unknown Object (File)
	Wed, May 1, 18:43

	Unknown Object (File)
	Thu, Apr 25, 13:35

	Unknown Object (File)
	Thu, Apr 25, 13:35

	Unknown Object (File)
	Thu, Apr 25, 13:12

View All 84 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15316: PHUITagView and similar: it's unclear whenever 'href' should be just a string

Commits

rPbcfcd9acfc12: Unify type-checking for `setHref()` type methods

Summary

Adopt PhutilURI::checkHrefType() to unify type-check of some PHUI objects.

Ref T15316. Depends on D25356.

Test Plan

In production.

Diff Detail

Repository

Branch

check-href-type

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 690
Build 690: arc lint + arc unit

Event Timeline

avivey created this revision.Jul 24 2023, 13:23

Owners added a reviewer: O1: Blessed Committers.Jul 24 2023, 13:23

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 24 2023, 13:23

avivey requested review of this revision.Jul 24 2023, 13:23

Harbormaster completed remote builds in B690: Diff 1156.Jul 24 2023, 13:23

avivey retitled this revision from Unify type-checking for `setHref()` type methods to (phorge) Unify type-checking for `setHref()` type methods.Jul 24 2023, 13:25

avivey mentioned this in D25356: (arc) Unify type-checking for `setHref()` type methods.Jul 24 2023, 19:32

avivey mentioned this in rARC6c6f47bf9cf6: (arc) Unify type-checking for `setHref()` type methods.Jul 24 2023, 19:34

valerio.bozzolan added inline comments.Jul 26 2023, 06:56

src/view/phui/PHUITagView.php
106

valerio.bozzolan retitled this revision from (phorge) Unify type-checking for `setHref()` type methods to Unify type-checking for `setHref()` type methods.Jul 26 2023, 06:58

valerio.bozzolan edited the summary of this revision. (Show Details)

+1 with just that inline suggestion

Thanks

This revision is now accepted and ready to land.Aug 2 2023, 16:34

Closed by commit rPbcfcd9acfc12: Unify type-checking for `setHref()` type methods. · Explain WhyAug 12 2023, 15:39

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rPbcfcd9acfc12: Unify type-checking for `setHref()` type methods.

Revision Contents
Changeset List

Path

Size

Packages

src/

view/

phui/

PHUIObjectItemView.php

38 lines

O1: Blessed Committers

PHUITagView.php

11 lines

O1: Blessed Committers

Diff 1156

src/view/phui/PHUIObjectItemView.php

Loading...

src/view/phui/PHUITagView.php

Loading...