Paths

Table of Contentst

Differential D25998

Remove orphan CSS selectors in base/main-menu-view.css
ClosedPublic
Actions

Authored by aklapper on Thu, May 8, 13:06.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP0347f1f619bb: Remove orphan CSS selectors in base/main-menu-view.css

Summary

phabricator-application-menu-expanded
- Added in https://we.phorge.it/rPfed0a2a496536d5a2a22f712861383299fabd3bd, usage removed in https://we.phorge.it/rP6f5dab634db26a14ba2ee000a3cee75c9d6152fb from src/view/page/menu/PhabricatorMainMenuView.php
phabricator-core-menu-icon
- Added in https://we.phorge.it/rPe3f6bbfff888008fcdf88f620b6716ab5add209b, usage removed in https://we.phorge.it/rP20035fe9a8ed53f4616528b114df61465f1d1f46 and https://we.phorge.it/rP6f5dab634db26a14ba2ee000a3cee75c9d6152fb
phabricator-expand-search-menu
- Added in https://we.phorge.it/rP919bd4a03499305093d8882952a9dd3dac1c55a9, usage removed in https://we.phorge.it/rP6f5dab634db26a14ba2ee000a3cee75c9d6152fb from src/view/page/menu/PhabricatorMainMenuView.php
phabricator-main-menu-expand-button
- Added in https://we.phorge.it/rP3c7944d297b2416d568ca2a7ab1e5c212adb78ff, usage removed in https://we.phorge.it/rP6f5dab634db26a14ba2ee000a3cee75c9d6152fb
phabricator-main-menu-group-logo
- Added in https://we.phorge.it/rP3c7944d297b2416d568ca2a7ab1e5c212adb78ff, usage removed in https://we.phorge.it/rP54fe74d6216707267a1c818404507d2ee5ad82ad

Test Plan

Grep the code for each CSS selector (grep --exclude="*.css" -R 'some-search-string' .), also do partial searches, get no results.

Diff Detail

Repository

Branch

cssDead5 (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2020
Build 2020: arc lint + arc unit

Event Timeline

aklapper created this revision.Thu, May 8, 13:06

Owners added a reviewer: O1: Blessed Committers.Thu, May 8, 13:06

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptThu, May 8, 13:06

aklapper requested review of this revision.Thu, May 8, 13:06

Harbormaster completed remote builds in B1952: Diff 3006.Thu, May 8, 13:06

valerio.bozzolan accepted this revision.Tue, May 27, 19:55

valerio.bozzolan added inline comments.

webroot/rsrc/css/application/base/main-menu-view.css
39–42	✅ `grep -R 'group-logo' .`
105–106	✅ `grep -R 'expand-search-menu' .`
110–111	✅ `grep -R 'menu-expand-button' .`
339–343	✅ `grep -R application-menu-expanded -`
530–549	✅ `grep -R 'core-menu-icon' .`

This revision is now accepted and ready to land.Tue, May 27, 19:55

git rebase master

Harbormaster completed remote builds in B2020: Diff 3107.Tue, May 27, 21:27

Closed by commit rP0347f1f619bb: Remove orphan CSS selectors in base/main-menu-view.css. · Explain WhyWed, May 28, 07:47

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP0347f1f619bb: Remove orphan CSS selectors in base/main-menu-view.css.

Revision Contents
Changeset List

Path

Size

Packages

resources/

celerity/

O1: Blessed Committers

webroot/

rsrc/

css/

application/

base/

main-menu-view.css

35 lines

O1: Blessed Committers

Diff 3107

resources/celerity/map.php

Loading...

webroot/rsrc/css/application/base/main-menu-view.css

Loading...