Page MenuHomePhorge

Allow filtering tokens given by list of token
AcceptedPublic

Authored by taavi on Wed, Feb 5, 16:24.

Details

Summary

Adds a new filter to the page /token/given/ to specify the type of token awarded.

Closes T15988

Test Plan

Visited /token/ to see it works as before.

Specified a token type in the search menu, and checked that the results only include that token type.

Activate DarkConsole and inspect the Services tab to check the query with "burminate" has sense, and you see this:

SELECT * FROM `token_given`   WHERE (tokenPHID IN ('PHID-TOKN-misc-4'))   ORDER BY `id` DESC LIMIT 101

Removed the token type in the search menu, the results still include everything, like before.

Diff Detail

Repository
rP Phorge
Branch
tokens
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1685
Build 1685: arc lint + arc unit

Event Timeline

taavi requested review of this revision.Wed, Feb 5, 16:24

Maybe we need to rebase on top of 7955fe6df701 (I don't have the base af404703cbe9 locally)

Maybe we need to rebase on top of 7955fe6df701 (I don't have the base af404703cbe9 locally)

I am still a bit confused on how to arc properly but I think this is rebased now? (At least it's rebased on top of what arc patch D25863 gives me locally.)

valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan edited the test plan for this revision. (Show Details)

(Don't worry, I'm also super confused by arc now. lol - it still does not apply cleanly to me, so I've downloaded the patch...)

Works on my computer! Thanks! And seems very Phorgi. Please kindly wait a cute week to attract eyeballs.

This revision is now accepted and ready to land.Wed, Feb 5, 17:36