Show table of content in left whitespace area in wide screens (width >= 1792px)
Closes T15920
Details
Details
- Reviewers
aklapper - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15920: Make table of contents visible when using wide screens
- Commits
- rP9448e815721c: Show table of contents by default on wide screens
- Open Phriction wiki page in browser which contain a number of chapter titles
- Open Responsive Design Mode in browser (Ctrl-Shift-M in Firefox) and test different width's of the page (e.g. 1024, 1280, 1440, 1600, 1920, ...)
- Open Remarkup Reference at /book/phorge/article/remarkup/ and repeat step 2
- Open a Differential revision to confirm that the unrelated ToC panel has no changes
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Thanks. Maybe it happens only to me but if my content is very short I see an UX regression
Comment Actions
Updating D25790: Make table of contents visible when using wide screens
Actions-curtain position fixed
Comment Actions
@mturdus: Thanks for the patch! I tested this locally on a wiki page with a bunch of sections and on http://phorge.localhost/book/phorge/article/remarkup/ ; and on Differential's /D1 where it does not affect the ToC panel (good).
I'm tempted to accept this, only thing I'm wondering: Could you explain what is the intention behind the margin-left: 32px; and the left: 50px;? What would happen if they were left out?
Comment Actions
The margin-left:32px removed a bit of the spacing between the toc and the content in a page without a curtain (e.g. the remarkup syntax page):
Those were just for the looks, but this is of course personal.
I can remove them if you want.
I thought that the text with a curtain (e.g. a phriction wiki page) was a bit too far to the left when the left:50px was missing:
The margin-left:32px removed a bit of the spacing between the toc and the content in a page without a curtain (e.g. the remarkup syntax page):
