Differential D25385

Replace dedicated Commit Field with an existing one
ClosedPublic
Actions

Authored by avivey on Aug 11 2023, 18:36.

Details

Reviewers

Sten

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15600: arc patch broken - class "DifferentialTestCommitMessageField" must define a "FIELDKEY" constant

Commits

rP56789a2fa681: Replace dedicated Commit Field with an existing one
rPeb0bb1736891: Replace dedicated Commit Field with an existing one

Summary

fix T15600

Test Plan

arc diff against this

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avivey created this revision.Aug 11 2023, 18:36

Owners added a reviewer: O1: Blessed Committers.Aug 11 2023, 18:36

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptAug 11 2023, 18:36

avivey requested review of this revision.Aug 11 2023, 18:36

Harbormaster completed remote builds in B743: Diff 1232.Aug 11 2023, 18:36

Minimal fix to the issue as discussed...

This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2023, 18:43

Closed by commit rPeb0bb1736891: Replace dedicated Commit Field with an existing one. · Explain Why

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rPeb0bb1736891: Replace dedicated Commit Field with an existing one.

avivey mentioned this in 2023 Week 32.Aug 11 2023, 18:48

avivey added a commit: rP56789a2fa681: Replace dedicated Commit Field with an existing one.Aug 25 2023, 11:54

Revision Contents
Changeset List

Path

Size

Packages

src/

__phutil_library_map__.php

O1: Blessed Committers

applications/

differential/

field/

DifferentialTestCommitMessageField.php

O1: Blessed Committers

__tests__/

DifferentialCommitMessageFieldTestCase.php

2 lines

O1: Blessed Committers

Diff 1233

View Options

src/__phutil_library_map__.php

View Options

src/applications/differential/field/DifferentialTestCommitMessageField.php

View Options

src/applications/differential/field/tests/DifferentialCommitMessageFieldTestCase.php

Replace dedicated Commit Field with an existing oneClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1233

src/__phutil_library_map__.php

src/applications/differential/field/DifferentialTestCommitMessageField.php

src/applications/differential/field/__tests__/DifferentialCommitMessageFieldTestCase.php

Replace dedicated Commit Field with an existing one
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/differential/field/tests/DifferentialCommitMessageFieldTestCase.php