This is a fix for running Phorge on PHP 8.2+. Other fixes were already merged.
Closes T15536
Differential D25256
T15064: PHP8 related corrections mturdus on May 29 2023, 10:11. Authored by
Details
This is a fix for running Phorge on PHP 8.2+. Other fixes were already merged. Closes T15536 Unclear.
Diff Detail
Event TimelineComment Actions Thanks Have you your stack traces before this was happening? Please share somewhere :) You are now a Trusted Contributors
Comment Actions These are the stack traces: [Mon May 29 10:55:20.640772 2023] [php:notice] [pid 18588:tid 140379590485696] [client ::1:40142] [2023-05-29 08:55:20] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261] [Mon May 29 11:42:29.478375 2023] [php:notice] [pid 22530:tid 140379556914880] [client ::1:52076] [2023-05-29 09:42:29] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261] [Mon May 29 12:44:50.903224 2023] [php:notice] [pid 22843:tid 140378497861312] [client ::1:60778] [2023-05-29 10:44:50] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261] [Mon May 29 12:52:28.549997 2023] [php:notice] [::1:53274] [2023-05-29 10:52:28] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261] [Mon May 29 12:54:11.080086 2023] [php:notice] [::1:42166] [2023-05-29 10:54:11] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261] [2023-05-29 10:56:41] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261] #0 PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/metamta/management/PhabricatorMailManagementSendTestWorkflow.php:77] #1 PhabricatorMailManagementSendTestWorkflow::execute(PhutilArgumentParser) called at [<arcanist>/src/parser/argument/PhutilArgumentParser.php:492] #2 PhutilArgumentParser::parseWorkflowsFull(array) called at [<arcanist>/src/parser/argument/PhutilArgumentParser.php:377] #3 PhutilArgumentParser::parseWorkflows(array) called at [<phorge>/scripts/mail/manage_mail.php:21] Pull of 'R4' failed: [Mon May 29 13:13:30.188466 2023] [php:notice] [::1:38826] [2023-05-29 11:13:30] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261] I was unable to reproduce these 2: The fix for src/applications/search/controller/PhabricatorSearchController.php does not generate a stack trace in the httpd error_log.
Comment Actions I verified some lines but I need more help in the others.
Comment Actions The change in src/applications/people/mail/PhabricatorPeopleEmailLoginMailEngine.php also seems to be solved somehow. (I can't comment on my own changes, so I mention it in here)
Comment Actions Only one fix remains. I set "unclear" in the test plan accordingly to T15536. If you still want to merge, just: arc diff D25256 arc land Thanks again :) |