Rename default SSH key name from Phabricator to Phorge
Closes T15274
Details
Details
- Reviewers
avivey valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15274: Rename default user SSH key name from Phabricator to Phorge
- Commits
- rP7b080db57c5b: Rename default SSH key name from Phabricator to Phorge
Go to https://we.phorge.it/settings/panel/ssh/ and select SSH Key Actions > Generate Keypair
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- master
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 270 Build 270: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 132 ms | PhabricatorCelerityTestCase::testCelerityMaps Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it.
ACTUAL VALUE
| |
| 12 ms | PhabricatorConduitTestCase::testConduitMethods 1 assertion passed. | |
| 0 ms | PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed. | |
| 0 ms | PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries 1 assertion passed. | |
| 4 ms | PhabricatorLibraryTestCase::testEverythingImplemented 1 assertion passed. | |
| View Full Test Results (1 Failed · 8 Passed) |
Event Timeline
Comment Actions
Whooops, sorry aklapper, we fixed now. Feel free to run git rebase master now, to make the unit test happy again, and land
Comment Actions
Fix PHP 8.1 "strlen(null)" exceptions to render the Account Creation page
Summary:
Fix numerous PHP 8.1 "strlen(null)" exceptions which block rendering the initial Account Creation page in a fresh Phorge installation
Test Plan:
After these code changes the account creation page got displayed (though without CSS and JS).
Comment Actions
arc is extremely demotivating (or under-documented). I ran
$:acko\> ../arcanist/bin/arc diff --base arc:prompt
Against which commit? 7bd4089a269490941236c020a040f104b9748ebeas I expected that to *skip* my last local commit (D25135, not landed yet) and thought it would use 7bd4089a269490941236c020a040f104b9748ebe as a base. Instead, D25135 got updated with unrelated changes.
I guess I completely misinterpreted https://we.phorge.it/D25131#4073.
Comment Actions
Hoping to be useful I restored the previous situation:
# rollback to previous version https://we.phorge.it/D25135?id=528 arc patch --diff 528 # make unit test happy git rebase master # update this online page arc diff --update D25135
Now you can just:
arc patch D25135 arc land
Comment Actions
I'm sorry for that feeling. I can suggest to split different proposals in different branches in the future
Sorry if I touched this but you don't deserve to suffer like this ihih
Comment Actions
In general for any fixup I just suggest to switch-off the brain and give a try to the native approach:
arc patch D25135 git commit -m "fix" git commit -m "fix" arc diff git commit -m "fix" git commit -m "fix" git commit -m "fix" arc diff git commit -m "AAAH FIX" arc diff
The logic is:
- arc patch creates a branch
- intermediate commits are just comments
- arc diff updates the web
This is probably a first step in somehow appreciating this nonsense swiss knife.
Comment Actions
@valerio.bozzolan: Thanks for the patience and explanations! Noted, and I'll stick to branches now to hopefully avoid creating more mess.