Page MenuHomePhorge

Rename default SSH key name from Phabricator to Phorge

Authored by aklapper on Apr 26 2023, 09:52.
Referenced Files
Unknown Object (File)
Thu, Sep 21, 01:21
Unknown Object (File)
Sun, Sep 10, 03:10
Unknown Object (File)
Sat, Sep 9, 12:16
Unknown Object (File)
Fri, Sep 8, 11:33
Unknown Object (File)
Fri, Sep 8, 06:57
Unknown Object (File)
Fri, Sep 8, 03:15
Unknown Object (File)
Mon, Sep 4, 10:46
Unknown Object (File)
Mon, Sep 4, 06:20



Rename default SSH key name from Phabricator to Phorge

Closes T15274

Test Plan

Go to and select SSH Key Actions > Generate Keypair

Diff Detail

rP Phorge
Lint Not Applicable
Tests Not Applicable

Event Timeline

avivey subscribed.

I think the unit tests will pass if you just rebase off of the current master.

This revision is now accepted and ready to land.Apr 26 2023, 10:02

mm, no, this is a new break in latest master.

Whooops, sorry aklapper, we fixed now. Feel free to run git rebase master now, to make the unit test happy again, and land

Fix PHP 8.1 "strlen(null)" exceptions to render the Account Creation page

Fix numerous PHP 8.1 "strlen(null)" exceptions which block rendering the initial Account Creation page in a fresh Phorge installation

Test Plan:
After these code changes the account creation page got displayed (though without CSS and JS).

arc is extremely demotivating (or under-documented). I ran

$:acko\> ../arcanist/bin/arc diff --base arc:prompt

    Against which commit? 7bd4089a269490941236c020a040f104b9748ebe

as I expected that to *skip* my last local commit (D25135, not landed yet) and thought it would use 7bd4089a269490941236c020a040f104b9748ebe as a base. Instead, D25135 got updated with unrelated changes.
I guess I completely misinterpreted

Hoping to be useful I restored the previous situation:

# rollback to previous version
arc patch --diff 528

# make unit test happy
git rebase master

# update this online page
arc diff --update D25135

Now you can just:

arc patch D25135
arc land

I'm sorry for that feeling. I can suggest to split different proposals in different branches in the future

Sorry if I touched this but you don't deserve to suffer like this ihih

In general for any fixup I just suggest to switch-off the brain and give a try to the native approach:

arc patch D25135
git commit -m "fix"
git commit -m "fix"
arc diff
git commit -m "fix"
git commit -m "fix"
git commit -m "fix"
arc diff
git commit -m "AAAH FIX"
arc diff

The logic is:

  • arc patch creates a branch
  • intermediate commits are just comments
  • arc diff updates the web

This is probably a first step in somehow appreciating this nonsense swiss knife.

@valerio.bozzolan: Thanks for the patience and explanations! Noted, and I'll stick to branches now to hopefully avoid creating more mess.