PHP 8.1 "preg_match(null)" exception in javelin/markup.php when http_action not set
ClosedPublic
Actions

Authored by aklapper on Apr 22 2023, 07:37.

Details

Reviewers

avivey
valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15262: PHP 8.1 "preg_match(null)" exception in javelin/markup.php when http_action not set

Commits

rP935d7120ee32: PHP 8.1 "preg_match(null)" exception in javelin/markup.php when http_action not…

Summary

Accessing a project's workboard URL of a non-existing workboard shows RunTimeException in PHP 8.1:

preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated

Closes T15262

Test Plan

Page whether to create a workboard for a project was displayed after this change

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Apr 22 2023, 07:37

Owners added a reviewer: O1: Blessed Committers.Apr 22 2023, 07:37

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptApr 22 2023, 07:37

aklapper requested review of this revision.Apr 22 2023, 07:37

Harbormaster completed remote builds in B261: Diff 508.Apr 22 2023, 07:38

Garr, this includes D25130. I am not a huge fan of arc's "commit everything or nothing" though I did use arc diff --create already.

In D25131#4070, @aklapper wrote:

Garr, this includes D25130. I am not a huge fan of arc's "commit everything or nothing" though I did use arc diff --create already.

You can use arc diff --base HEAD~ to only take one commit for the revision.

avivey accepted this revision.Apr 22 2023, 08:36

This revision is now accepted and ready to land.Apr 22 2023, 08:36

valerio.bozzolan edited the summary of this revision. (Show Details)Apr 22 2023, 09:02

sgtm

src/aphront/AphrontRequest.php
451	Thanks. This fix for PHP 8.1 should be very OK since the default is NULL and nothing alien (like false) should arrive causing the related crash from the phutil check. If an alien value will arrive causing a crash, we can just discuss that specific case again.
451	Thanks. This fix for PHP 8.1 should be very OK since the default is NULL and nothing alien (like false) should arrive causing the related crash from the phutil check. If an alien value will arrive causing a crash, we can just discuss that specific case again.
src/infrastructure/javelin/markup.php
83	Thanks. This fix for PHP 8.1 should be very OK since the default is NULL and nothing alien (like false) should arrive causing the related crash from the phutil check. If an alien value will arrive causing a crash, we can just discuss that specific case again. Since preg_match returns zero for zero matches, this seems the most appropriate fix to me.