Marks Line Numbers in Diffusion File Preview as unselectable
- Group Reviewers
O1: Blessed Committers
- rP69b2710af9c0: Prevent Line Numbers in Diffusion being copied as Tabs
- Select multiple Lines from a File Preview in Diffusion
- Copy them into a Text Editor
- The Leading Tabs should no longer included
- rP Phorge
No Test Coverage
- Build Status
Buildable 50 Build 50: arc lint + arc unit
I am not seeing this behavior. (Using Edge)
I did this
- When to rP repo in diffusion
- Clicked on .arcconfig file https://we.phorge.it/source/phorge/browse/master/.arcconfig
- Copied all of the lines
- Pasted into notepad.
I did not get tabs
l got this behaviour using Firefox on a Linux system. I have no Windows at Hand Right now, but will check it tomorow with different browsers.
Happens with Firefox on Windows too. Chome and Edge are not including tabs, but when selecting from bottom to top and ending the selection while hovering a line number, one tab gets copied. This is also prevented with this patch.
I tried on Firefox on mac and there are tabs included
I think this change makes sense to me.
Should we be using these browser-specific flags or are these ancient?
Honestly I have no idea. I am not an css expert.
Looks like Safari still requires the vendor prefix
Chrome supports without vendor prefix as of about 2016, Edge as of 2018
We should keep the webkit one for sure...
Let’s update to include the same set of user-select cross-browser as the blame info
Thanks for checking. My question is aimed at being consistent and not necessarily updating this css here, but making sure the user-select addition above is accounting for the same compatibility.
I tested this revision on Edge just to make sure there were no negative side effects - No issues to report.
It seems like only the WebKit variant may still be necessary. What do you think about updating both areas to just have the WebKit version in addition to the standard?
Things seem wildly inconsistent for this particular css string https://we.phorge.it/source/phorge/browse/master/?grep=user-select
Ah interesting. Could we follow the information you found and just include the WebKit one for now. I’m not as concerned with consistency after your findings. I appreciate that you investigated!
@Leon95 - I think this revision will be approved with just including the webkit alternate -
Since it matches the other user select that’s setup in this file this is fine but it could just be the standard + WebKit one
I think we determined that the only additional line is this WebKit one