Page MenuHomePhorge

Affects-WikimediaTag
ActivePublic

Members

  • This project does not have any members.
  • View All

Details

Description

Task that can be used to mark something that affects or involves Wikimedia Phabricator.

https://phabricator.wikimedia.org/

Recent Activity

Fri, Oct 25

aklapper added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing.

This exception happens once $rule in the loop foreach ($this->getMarkupRules() as $rule) in PhutilRemarkupBlockRule::applyRules($text) becomes ProjectRemarkupRule. That's where it blows up.

Fri, Oct 25, 10:19 · Bug Reports, Remarkup, Affects-Wikimedia

Aug 14 2024

valerio.bozzolan added a comment to T15916: Conduit maniphest.gettasktransactions: include metadata and title.

Maybe interesting, there is this different non-deprecated API:

Aug 14 2024, 16:24 · Maniphest, Affects-Wikimedia
valerio.bozzolan updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Aug 14 2024, 16:05 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan added a revision to T15916: Conduit maniphest.gettasktransactions: include metadata and title: D25777: Make maniphest.gettasktransactions include metadata and title.
Aug 14 2024, 16:02 · Maniphest, Affects-Wikimedia
valerio.bozzolan created T15916: Conduit maniphest.gettasktransactions: include metadata and title.
Aug 14 2024, 16:02 · Maniphest, Affects-Wikimedia

Aug 7 2024

aklapper closed T15472: Support Open Graph protocol (at least in Maniphest) as Resolved by committing rP89778dc9e617: Add Open Graph protocol meta tags to Maniphest task pages.
Aug 7 2024, 11:54 · User-valerio.bozzolan, Affects-Wikimedia, Maniphest

Aug 5 2024

aklapper added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing.

This is an issue in https://we.phorge.it/source/phorge/browse/master/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php . In getObjectEmbedPattern(), preg_quote($prefix) returns \# and the method finally returns (\B{\#([^.\s?!,:;{}#\(\)"'\*/~]+(?:[^\s?!,:;{}#\(\)"'\*/~]*[^.\s?!,:;{}#\(\)"'\*/~]+)*)([,\s](?:[^}\\]|\\.)*)?}\B)u.
Within apply($text), $text becomes null after that first preg_replace_callback, so the second call barks.

Aug 5 2024, 12:44 · Bug Reports, Remarkup, Affects-Wikimedia

Aug 2 2024

aklapper added a comment to T15100: [Feature request] Option to measure WIP limits based on card count instead of points, to more closely adhere to Kanban standards..

I'm not skilled enough to look into the bigger picture, however maybe the Edit Column dialog could have a third field apart from Name and Point Limit to also have Task Limit (or Card Limit?). Point Limit and Task Limit then must be mutually exclusive (do not allow to set both for a column, or even...board?), somehow.

Aug 2 2024, 10:28 · Feature Requests, Maniphest, Discussion Needed, Affects-Wikimedia, Workboard

May 20 2024

aklapper added a revision to T15472: Support Open Graph protocol (at least in Maniphest): D25668: Add Open Graph protocol meta tags to Maniphest task pages.
May 20 2024, 20:32 · User-valerio.bozzolan, Affects-Wikimedia, Maniphest

May 15 2024

pppery added a project to T15055: Import translations from translatewiki.net: Localization.
May 15 2024, 05:12 · Localization, Affects-Wikimedia, Phorge
pppery merged T15079: Upstream translatewiki.net's changes into T15055: Import translations from translatewiki.net.
May 15 2024, 05:11 · Localization, Affects-Wikimedia, Phorge

May 2 2024

aklapper added a comment to T15407: People: profile picture should be editable by their author (not by "No one").

I do not (yet?) understand the use case of this task.

May 2 2024, 16:34 · User-valerio.bozzolan, People
valerio.bozzolan moved T15407: People: profile picture should be editable by their author (not by "No one") from Backlog to Code Sprint Candidate on the User-valerio.bozzolan board.

Indeed reported from a Wikimedia user about Wikimedia Phabricator.

May 2 2024, 16:17 · User-valerio.bozzolan, People

Apr 29 2024

valerio.bozzolan closed T15163: The Task Cover Image is visible only to the uploader (invisible to Task participants) as Resolved by committing rP3367fe0017b1: Drag & Drop Task Cover Image: also attach.
Apr 29 2024, 15:34 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard
valerio.bozzolan closed T15703: Workboard Cover Image: the cropped "Transform" is orphan, a subtask of T15163: The Task Cover Image is visible only to the uploader (invisible to Task participants), as Resolved.
Apr 29 2024, 15:34 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard

Apr 25 2024

waldyrious removed a watcher for Affects-Wikimedia: waldyrious.
Apr 25 2024, 22:07
Iniquity added a comment to T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards.

It seems to me that this problem can be solved with an additional setting that turns this functionality on or off.

Apr 25 2024, 19:10 · Discussion Needed, Affects-Wikimedia, Workboard

Mar 28 2024

aklapper placed T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID' up for grabs.
Mar 28 2024, 19:54 · Affects-Wikimedia, Bug Reports
aklapper added a subtask for T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID': T15764: Moving tasks on a workboard via the "Add Action" dropdown does not update column and column positions tables.
Mar 28 2024, 19:54 · Affects-Wikimedia, Bug Reports

Mar 26 2024

avivey closed T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description as Resolved by committing rP216d308507ed: Fix Project Hovercard rendering @mention.
Mar 26 2024, 18:07 · Affects-Wikimedia, Bug Reports
avivey added a revision to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description: D25562: Fix Project Hovercard rendering @mention.
Mar 26 2024, 15:40 · Affects-Wikimedia, Bug Reports
avivey added a comment to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.

It might not happen on any other card, because we might not be rendering Remarkup on any other card. Interesting....

Mar 26 2024, 10:46 · Affects-Wikimedia, Bug Reports
avivey added a comment to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.

So this is quite an edge-case:

  • PhabricatorMentionRemarkupRule wants to give the mention a different color, depending on if the user can view the "context object", in this case the Project.
  • There's an automatic rule, saying a member of a project can always view the project
  • When loading the project for the hovercard, we don't bother loading all the member list
  • When loading the user for the mention, we don't bother loading all its projects
  • so data is not available at the rendering point.
Mar 26 2024, 10:39 · Affects-Wikimedia, Bug Reports
avivey claimed T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.
Mar 26 2024, 10:23 · Affects-Wikimedia, Bug Reports

Mar 25 2024

valerio.bozzolan added a comment to T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.

Another good simple candidate GDPR-friendly:

Mar 25 2024, 10:36 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan added a revision to T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php): D25559: Update unit test of InterpreterBlockRule for "a {{{a}}}".
Mar 25 2024, 07:18 · Bug Reports
valerio.bozzolan added a revision to T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php): D25415: Make InterpreterBlockRule regex only match on valid interpreter names.
Mar 25 2024, 07:12 · Bug Reports

Mar 24 2024

valerio.bozzolan triaged T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description as High priority.

Ouch

Mar 24 2024, 15:46 · Affects-Wikimedia, Bug Reports

Mar 21 2024

aklapper updated the task description for T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.
Mar 21 2024, 22:34 · Affects-Wikimedia, Bug Reports
aklapper added a comment to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.

Also note that we have a similar PhabricatorDataNotAttachedException in PhabricatorRepositoryCommit (via getRepository()) in downstream https://phabricator.wikimedia.org/T360714. It's without reproduction steps but sounds a bit similar.

Mar 21 2024, 20:40 · Affects-Wikimedia, Bug Reports
aklapper updated the task description for T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.
Mar 21 2024, 20:21 · Affects-Wikimedia, Bug Reports
aklapper closed T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field as Resolved by committing rPd42b3eb0b17a: Fix "Map omits required key" exception by comparing result order against modern….
Mar 21 2024, 18:26 · Affects-Wikimedia, Bug Reports

Mar 15 2024

aklapper claimed T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID'.
Mar 15 2024, 16:45 · Affects-Wikimedia, Bug Reports

Mar 10 2024

valerio.bozzolan added a comment to T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field.

Maybe unrelated. But after we fix PhabricatorCursorPagedPolicyAwareQuery, maybe we will find a crash test also for the first two lines:

Mar 10 2024, 16:25 · Affects-Wikimedia, Bug Reports
valerio.bozzolan triaged T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field as Normal priority.

Interestingly I was able to reproduce, but only creating 101+ tasks manually and going to the next page. So after that ?after=100 is introduced.

Mar 10 2024, 12:05 · Affects-Wikimedia, Bug Reports

Jan 4 2024

aklapper added a revision to T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field: D25504: Fix "Map omits required key" exception by comparing result order against modern field keys.
Jan 4 2024, 09:17 · Affects-Wikimedia, Bug Reports

Dec 31 2023

valerio.bozzolan renamed T15163: The Task Cover Image is visible only to the uploader (invisible to Task participants) from Auto-Attach a File when dropping it as Task cover image to The Task Cover Image is visible only to the uploader (invisible to Task participants).
Dec 31 2023, 00:21 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard

Dec 18 2023

aklapper closed T15688: "Undefined index: PHID-PROJ-***" in project.search API when project_customfieldstorage table has additional fields not requested, a subtask of T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge, as Resolved.
Dec 18 2023, 11:46 · Discussion Needed, Affects-Wikimedia

Dec 14 2023

20after4 added a subtask for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: T15694: Consider adopting the "search results context highlighting" feature from Wikimedia's fork.
Dec 14 2023, 17:33 · Discussion Needed, Affects-Wikimedia
20after4 updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Dec 14 2023, 17:32 · Discussion Needed, Affects-Wikimedia
20after4 added a comment to T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.

Here's another one that I think deserves to be upstreamed: https://phabricator.wikimedia.org/T230787 adds context and search term highlights to fulltext search results. Currently Phorge and upstream Phabricator only show matching document titles with highlights on keywords in the title but not the body.
The efficiency of my solution is questionable, however, it's working well enough for Wikimedia's use of the feature.

Dec 14 2023, 17:04 · Discussion Needed, Affects-Wikimedia

Dec 8 2023

soloturn added a comment to T15100: [Feature request] Option to measure WIP limits based on card count instead of points, to more closely adhere to Kanban standards..

there is a presentation from eric brechner, who was in microsofts xbox development, about kanban. he does it on whiteboard, extremely sinple:
https://www.youtube.com/watch?v=CD0y-aU1sXo

Dec 8 2023, 08:17 · Feature Requests, Maniphest, Discussion Needed, Affects-Wikimedia, Workboard

Dec 7 2023

valerio.bozzolan updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Dec 7 2023, 10:33 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan added a subtask for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: T15688: "Undefined index: PHID-PROJ-***" in project.search API when project_customfieldstorage table has additional fields not requested.
Dec 7 2023, 10:32 · Discussion Needed, Affects-Wikimedia

Dec 6 2023

aklapper closed T15686: Include 'published' date in Phame atom feeds, a subtask of T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge, as Resolved.
Dec 6 2023, 19:34 · Discussion Needed, Affects-Wikimedia
aklapper closed T15686: Include 'published' date in Phame atom feeds as Resolved by committing rP6c8329fb6614: Include 'published' date of posts in Phame Atom feeds.
Dec 6 2023, 19:34 · Affects-Wikimedia, Feature Requests
valerio.bozzolan added a project to T15686: Include 'published' date in Phame atom feeds: Affects-Wikimedia.
Dec 6 2023, 06:28 · Affects-Wikimedia, Feature Requests
valerio.bozzolan updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Dec 6 2023, 06:21 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan added a subtask for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: T15686: Include 'published' date in Phame atom feeds.
Dec 6 2023, 06:21 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan moved T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge from Backlog to Discussion Needed on the Affects-Wikimedia board.
Dec 6 2023, 06:20 · Discussion Needed, Affects-Wikimedia