Page MenuHomePhorge

Affects-WikimediaTag
ActivePublic

Members

  • This project does not have any members.
  • View All

Details

Description

Task that can be used to mark something that affects or involves Wikimedia Phabricator.

https://phabricator.wikimedia.org/

Recent Activity

Today

Cigaryno added a project to T15482: Conduit method for Legalpad signatures: Legalpad.
Fri, Jan 17, 11:14 · Legalpad, Conduit, Affects-Wikimedia
Cigaryno added a project to T15175: Granularize Legalpad view/edit/sign permissions: Legalpad.
Fri, Jan 17, 11:14 · Legalpad, Policy, User-valerio.bozzolan, Affects-Wikimedia
Cigaryno moved T15323: Add support for embedding Videos from Wikimedia Commons into Remarkup from Backlog to Feature Requests on the Affects-Wikimedia board.
Fri, Jan 17, 11:08 · Feature Requests, Remarkup, Affects-Wikimedia

Wed, Jan 1

Cigaryno updated the task description for T15055: Import translations from translatewiki.net.
Wed, Jan 1, 14:33 · Localization, Affects-Wikimedia, Phorge

Tue, Dec 31

Cigaryno moved T15323: Add support for embedding Videos from Wikimedia Commons into Remarkup from Backlog to Feature Requests on the Remarkup board.
Tue, Dec 31, 11:01 · Feature Requests, Remarkup, Affects-Wikimedia
Cigaryno added a project to T15323: Add support for embedding Videos from Wikimedia Commons into Remarkup: Feature Requests.
Tue, Dec 31, 11:01 · Feature Requests, Remarkup, Affects-Wikimedia

Sun, Dec 29

Iniquity added a comment to T15100: [Feature request] Option to measure WIP limits based on card count instead of points, to more closely adhere to Kanban standards..

I'm not skilled enough to look into the bigger picture, however maybe the Edit Column dialog could have a third field apart from Name and Point Limit to also have Task Limit (or Card Limit?). Point Limit and Task Limit then must be mutually exclusive (do not allow to set both for a column, or even...board?), somehow.

Sun, Dec 29, 21:28 · Feature Requests, Maniphest, Discussion Needed, Affects-Wikimedia, Workboard
Cigaryno moved T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge from Backlog to Wikimedia on the Discussion Needed board.
Sun, Dec 29, 17:39 · Discussion Needed, Affects-Wikimedia
Cigaryno moved T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards from Backlog to Wikimedia on the Discussion Needed board.
Sun, Dec 29, 17:38 · Discussion Needed, Affects-Wikimedia, Workboard

Sat, Dec 28

Cigaryno moved T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards from Backlog to Discussion Needed on the Workboard board.
Sat, Dec 28, 10:58 · Discussion Needed, Affects-Wikimedia, Workboard
Cigaryno moved T15100: [Feature request] Option to measure WIP limits based on card count instead of points, to more closely adhere to Kanban standards. from Backlog to Feature Requests on the Maniphest board.
Sat, Dec 28, 10:40 · Feature Requests, Maniphest, Discussion Needed, Affects-Wikimedia, Workboard

Tue, Dec 24

Cigaryno moved T15125: Unknown edge constant "26"! when deleting a file with old attachment edges from Backlog to Bug Reports on the Files board.
Tue, Dec 24, 10:02 · Affects-Wikimedia, Files, Bug Reports
pppery added a comment to T15055: Import translations from translatewiki.net.

I've added the existing translations repo to https://we.phorge.it/w/community_resources/ since that's trivial. I agree something better should be done.

Tue, Dec 24, 02:34 · Localization, Affects-Wikimedia, Phorge

Mon, Dec 23

Cigaryno moved T15233: Projects: add "Tasks", "Revisions" menu items from Backlog to Feature Requests on the Affects-Wikimedia board.
Mon, Dec 23, 16:38 · Feature Requests, Affects-Wikimedia
Cigaryno added a project to T15233: Projects: add "Tasks", "Revisions" menu items: Feature Requests.
Mon, Dec 23, 16:38 · Feature Requests, Affects-Wikimedia

Sun, Dec 22

Cigaryno moved T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards from Backlog to Discussion Needed on the Affects-Wikimedia board.
Sun, Dec 22, 07:07 · Discussion Needed, Affects-Wikimedia, Workboard
Cigaryno moved T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID' from Backlog to Bug Reports on the Affects-Wikimedia board.
Sun, Dec 22, 07:07 · Affects-Wikimedia, Bug Reports
Cigaryno moved T15653: Prefilled tag in task form opened from workboard column deletes any project tags defined by form from Backlog to Bug Reports on the Affects-Wikimedia board.
Sun, Dec 22, 07:07 · Affects-Wikimedia, Bug Reports

Dec 17 2024

aklapper added a comment to T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.

Wow. Assuming the line is the one with phutil_nonempty_string($branch), why branch "main" is considered a number?

Dec 17 2024, 17:24 · Affects-Wikimedia

Dec 16 2024

valerio.bozzolan added a comment to T15125: Unknown edge constant "26"! when deleting a file with old attachment edges.

The current workaround I'm proposing is just:

Dec 16 2024, 07:54 · Affects-Wikimedia, Files, Bug Reports

Dec 10 2024

valerio.bozzolan added a project to T15405: Slowvote Application: allow to change the Creation Policy (Default Edit Policy): Spam mitigation.
Dec 10 2024, 13:56 · Spam mitigation, User-valerio.bozzolan, Policy, Affects-Wikimedia

Dec 5 2024

pppery closed T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing as Resolved by committing rP9c73d62c4466: Rewrite regex for project names to be not prone to catastrophic backtracking.
Dec 5 2024, 17:40 · Bug Reports, Remarkup, Affects-Wikimedia

Nov 29 2024

valerio.bozzolan triaged T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php as Normal priority.
Nov 29 2024, 18:47 · Affects-Wikimedia
valerio.bozzolan updated the task description for T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.
Nov 29 2024, 18:47 · Affects-Wikimedia
valerio.bozzolan added a comment to T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.

BTW I think the page is reached by a crawler that is visiting a branch root on a specific commit:

Nov 29 2024, 18:42 · Affects-Wikimedia
valerio.bozzolan added a comment to T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.

Wow. Assuming the line is the one with phutil_nonempty_string($branch), why branch "main" is considered a number?

Nov 29 2024, 18:36 · Affects-Wikimedia
aklapper added a comment to T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.

Finally got a reproducer URI in downstream:

Nov 29 2024, 12:36 · Affects-Wikimedia

Nov 26 2024

aklapper closed T15916: Conduit maniphest.gettasktransactions: include metadata and title, a subtask of T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge, as Resolved.
Nov 26 2024, 13:08 · Discussion Needed, Affects-Wikimedia
aklapper closed T15916: Conduit maniphest.gettasktransactions: include metadata and title as Resolved by committing rP6ec5c88bee24: Make maniphest.gettasktransactions include metadata and title.
Nov 26 2024, 13:08 · Maniphest, Affects-Wikimedia

Nov 23 2024

pppery claimed T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.
Nov 23 2024, 21:17 · Bug Reports, Remarkup, Affects-Wikimedia
pppery renamed T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing from RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing to RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.
Nov 23 2024, 21:17 · Bug Reports, Remarkup, Affects-Wikimedia
pppery added a revision to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing: D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.
Nov 23 2024, 21:08 · Bug Reports, Remarkup, Affects-Wikimedia
pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Digging deeper, the problem is specific to ProjectRemarkupRule::getObjectIDPattern. That returns:

Nov 23 2024, 20:45 · Bug Reports, Remarkup, Affects-Wikimedia
pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Step 2: Remove irrelevant character class exclusions:

Nov 23 2024, 20:33 · Bug Reports, Remarkup, Affects-Wikimedia
pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Disentangling that monster regex, step 1:

Nov 23 2024, 20:30 · Bug Reports, Remarkup, Affects-Wikimedia
pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Indeed https://devina.io/redos-checker says the aformentioned regex is exponential time worst-case

Nov 23 2024, 20:20 · Bug Reports, Remarkup, Affects-Wikimedia
pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

I monkeypatched the code to print preg_last_error when the problematic preg_match returns null. The error is "Backtrack limit exhausted".

Nov 23 2024, 20:18 · Bug Reports, Remarkup, Affects-Wikimedia

Oct 25 2024

aklapper added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

This exception happens once $rule in the loop foreach ($this->getMarkupRules() as $rule) in PhutilRemarkupBlockRule::applyRules($text) becomes ProjectRemarkupRule. That's where it blows up.

Oct 25 2024, 10:19 · Bug Reports, Remarkup, Affects-Wikimedia

Aug 14 2024

valerio.bozzolan added a comment to T15916: Conduit maniphest.gettasktransactions: include metadata and title.

Maybe interesting, there is this different non-deprecated API:

Aug 14 2024, 16:24 · Maniphest, Affects-Wikimedia
valerio.bozzolan updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Aug 14 2024, 16:05 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan added a revision to T15916: Conduit maniphest.gettasktransactions: include metadata and title: D25777: Make maniphest.gettasktransactions include metadata and title.
Aug 14 2024, 16:02 · Maniphest, Affects-Wikimedia
valerio.bozzolan created T15916: Conduit maniphest.gettasktransactions: include metadata and title.
Aug 14 2024, 16:02 · Maniphest, Affects-Wikimedia

Aug 7 2024

aklapper closed T15472: Support Open Graph protocol (at least in Maniphest) as Resolved by committing rP89778dc9e617: Add Open Graph protocol meta tags to Maniphest task pages.
Aug 7 2024, 11:54 · User-valerio.bozzolan, Affects-Wikimedia, Maniphest

Aug 5 2024

aklapper added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

This is an issue in https://we.phorge.it/source/phorge/browse/master/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php . In getObjectEmbedPattern(), preg_quote($prefix) returns \# and the method finally returns (\B{\#([^.\s?!,:;{}#\(\)"'\*/~]+(?:[^\s?!,:;{}#\(\)"'\*/~]*[^.\s?!,:;{}#\(\)"'\*/~]+)*)([,\s](?:[^}\\]|\\.)*)?}\B)u.
Within apply($text), $text becomes null after that first preg_replace_callback, so the second call barks.

Aug 5 2024, 12:44 · Bug Reports, Remarkup, Affects-Wikimedia

Aug 2 2024

aklapper added a comment to T15100: [Feature request] Option to measure WIP limits based on card count instead of points, to more closely adhere to Kanban standards..

I'm not skilled enough to look into the bigger picture, however maybe the Edit Column dialog could have a third field apart from Name and Point Limit to also have Task Limit (or Card Limit?). Point Limit and Task Limit then must be mutually exclusive (do not allow to set both for a column, or even...board?), somehow.

Aug 2 2024, 10:28 · Feature Requests, Maniphest, Discussion Needed, Affects-Wikimedia, Workboard

May 20 2024

aklapper added a revision to T15472: Support Open Graph protocol (at least in Maniphest): D25668: Add Open Graph protocol meta tags to Maniphest task pages.
May 20 2024, 20:32 · User-valerio.bozzolan, Affects-Wikimedia, Maniphest

May 15 2024

pppery added a project to T15055: Import translations from translatewiki.net: Localization.
May 15 2024, 05:12 · Localization, Affects-Wikimedia, Phorge
pppery merged T15079: Upstream translatewiki.net's changes into T15055: Import translations from translatewiki.net.
May 15 2024, 05:11 · Localization, Affects-Wikimedia, Phorge

May 2 2024

aklapper added a comment to T15407: People: profile picture should be editable by their author (not by "No one").

I do not (yet?) understand the use case of this task.

May 2 2024, 16:34 · Policy, User-valerio.bozzolan, People
valerio.bozzolan moved T15407: People: profile picture should be editable by their author (not by "No one") from Backlog to Code Sprint Candidate on the User-valerio.bozzolan board.

Indeed reported from a Wikimedia user about Wikimedia Phabricator.

May 2 2024, 16:17 · Policy, User-valerio.bozzolan, People