pppery (Perry)
User

Projects

Trusted Contributors
Group

Calendar

User Details

User Since: Nov 22 2023, 04:24 (60 w, 2 d)
Availability: Available

Recent Activity
View All

Fri, Jan 10

pppery added a comment to D25861: Don't try to translate date elements used internally in AphrontFormDateControlValue.

All I did was look at the homepage and observe I saw "e. p. p" in the recent activity (and thus the translations somehow worked). That was more of a paranoia check for unintended side effects on other uses of the function, to make sure I didn't break date translation completely. You're welcome to test other UI things to make sure they're not affected if you wish.

Fri, Jan 10, 18:40

pppery updated the test plan for D25861: Don't try to translate date elements used internally in AphrontFormDateControlValue.

Fri, Jan 10, 04:44

pppery updated the diff for D25861: Don't try to translate date elements used internally in AphrontFormDateControlValue.

Fix lint

Fri, Jan 10, 04:44

pppery requested review of D25861: Don't try to translate date elements used internally in AphrontFormDateControlValue.

Fri, Jan 10, 04:42

pppery added a revision to T15811: Search exception when AM/PM string is localized in Calendar application: D25861: Don't try to translate date elements used internally in AphrontFormDateControlValue.

Fri, Jan 10, 04:42 · Localization, Bug Reports, Calendar

pppery added a comment to D25618: Avoid search exception for calendar events when using localized time formats.

In D25618#20068, @pppery wrote:

I think the behavior of not setting the timezone is probably correct, actually. GetFormattedDateFromParts below already constructs a date object again with the timezone set. So I think the timezone offset is being applied twice here.

(From reading the code, I don't have a means to test this)

And the date is read from the database so I don't think it can be malformed.

Fri, Jan 10, 04:21 · Calendar

Sun, Dec 29

Cigaryno awarded rPed6644f31757: Fix typos etc. a Like token.

Sun, Dec 29, 16:38

pppery closed Q161: strange things (typo and other) in Phabricator as resolved.

Sun, Dec 29, 16:36

pppery closed T15980: Handle typos from Q161 as Resolved by committing rPed6644f31757: Fix typos etc..

Sun, Dec 29, 16:36 · Good Starter Task

pppery closed D25860: Fix typos etc..

Sun, Dec 29, 16:36

pppery committed rPed6644f31757: Fix typos etc..

Fix typos etc.

Sun, Dec 29, 16:36

pppery updated the diff for D25860: Fix typos etc..

Per avivey

Sun, Dec 29, 16:33

pppery added a comment to Q161: strange things (typo and other) in Phabricator (Answer 201).

in PhabricatorDaemonManagementWorkflow.php: "25%%%%" (maybe too many % char?)

Sun, Dec 29, 02:59

pppery requested review of D25860: Fix typos etc..

Sun, Dec 29, 02:59

pppery added a revision to T15980: Handle typos from Q161: D25860: Fix typos etc..

Sun, Dec 29, 02:59 · Good Starter Task

Tue, Dec 24

pppery added a comment to T15055: Import translations from translatewiki.net.

I've added the existing translations repo to https://we.phorge.it/w/community_resources/ since that's trivial. I agree something better should be done.

Tue, Dec 24, 02:34 · Localization, Affects-Wikimedia, Phorge

pppery edited the content of Community Resources.

Tue, Dec 24, 02:32

pppery added a member for Trusted Contributors: • Mahabarata.

Tue, Dec 24, 02:21

pppery added a comment to Q161: strange things (typo and other) in Phabricator (Answer 201).

Filed https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/44 for the downstream issue.

Tue, Dec 24, 02:21

Dec 11 2024

pppery closed D25852: Fix typos in Harbormaster.

Dec 11 2024, 04:05

pppery committed rPc4f88847ef98: Fix typos in Harbormaster.

Fix typos in Harbormaster

Dec 11 2024, 04:05

pppery updated the summary of D25852: Fix typos in Harbormaster.

Dec 11 2024, 00:54

pppery updated the diff for D25852: Fix typos in Harbormaster.

And another typo

Dec 11 2024, 00:54

pppery requested review of D25852: Fix typos in Harbormaster.

Dec 11 2024, 00:48

Dec 5 2024

pppery closed D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.

Dec 5 2024, 17:40

pppery closed T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing as Resolved by committing rP9c73d62c4466: Rewrite regex for project names to be not prone to catastrophic backtracking.

Dec 5 2024, 17:40 · Bug Reports, Remarkup, Affects-Wikimedia

pppery committed rP9c73d62c4466: Rewrite regex for project names to be not prone to catastrophic backtracking.

Rewrite regex for project names to be not prone to catastrophic backtracking

Dec 5 2024, 17:40

pppery updated the diff for D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.

Rebase

Dec 5 2024, 17:39

Dec 1 2024

pppery updated the diff for D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.

Add the newlline

Dec 1 2024, 20:37

Nov 23 2024

pppery added a comment to D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.

https://devina.io/redos-checker says the new regex is still prone to polynomial backtracking, but that can happen only on extremely contrived input, whereas the old one was exponential on a common case.

Nov 23 2024, 21:22

pppery claimed T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Nov 23 2024, 21:17 · Bug Reports, Remarkup, Affects-Wikimedia

pppery renamed T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing from RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing to RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Nov 23 2024, 21:17 · Bug Reports, Remarkup, Affects-Wikimedia

pppery updated the test plan for D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.

Nov 23 2024, 21:16

pppery updated the diff for D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.

Fix lint

Nov 23 2024, 21:14

pppery added a revision to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing: D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.

Nov 23 2024, 21:08 · Bug Reports, Remarkup, Affects-Wikimedia

pppery requested review of D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.

Nov 23 2024, 21:08

pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Digging deeper, the problem is specific to ProjectRemarkupRule::getObjectIDPattern. That returns:

Nov 23 2024, 20:45 · Bug Reports, Remarkup, Affects-Wikimedia

pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Step 2: Remove irrelevant character class exclusions:

Nov 23 2024, 20:33 · Bug Reports, Remarkup, Affects-Wikimedia

pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Disentangling that monster regex, step 1:

Nov 23 2024, 20:30 · Bug Reports, Remarkup, Affects-Wikimedia

pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Indeed https://devina.io/redos-checker says the aformentioned regex is exponential time worst-case

Nov 23 2024, 20:20 · Bug Reports, Remarkup, Affects-Wikimedia

pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

I monkeypatched the code to print preg_last_error when the problematic preg_match returns null. The error is "Backtrack limit exhausted".

Nov 23 2024, 20:18 · Bug Reports, Remarkup, Affects-Wikimedia

Nov 22 2024

pppery created T15959: Modified files not counted in total when attaching files.

Nov 22 2024, 16:59 · Good Starter Task, Bug Reports, Files

Nov 12 2024

pppery added a project to T15931: All method search results in Diviner are 404 URIs: Diviner.

Nov 12 2024, 02:27 · Diviner

pppery added a project to T15932: All file search results in Diviner are 404 URIs: Diviner.

Nov 12 2024, 02:26 · Diviner

pppery added a project to T15943: Calendar: Call to a member function format() on null at $this->getQueryDateFrom($query)->getDateTime(): Calendar.

Nov 12 2024, 02:26 · Calendar

pppery added a project to T15903: Logged exceptions/errors should ignore user's language setting and be always in English: Localization.

Nov 12 2024, 02:25 · Localization

Aug 5 2024

pppery added a comment to T15903: Logged exceptions/errors should ignore user's language setting and be always in English.

Ideally strings not shown to the user would also not be wrapped in pht(...) at all to avoid wasting translator's time. This is contrary to the documentation inherited from old upstream at https://we.phorge.it/book/contrib/article/internationalization/, though,

Aug 5 2024, 16:22 · Localization

Aug 2 2024

pppery added a project to T15885: Herald rule referring to an invalid key silently fails: Herald.

Aug 2 2024, 18:57 · Bug Reports, Herald

pppery added a project to T15898: Restrict maximum task title length: Maniphest.

Aug 2 2024, 18:57 · Maniphest

pppery added a project to T15887: Herald rule referring to a non-existing action silently fails: Herald.

Aug 2 2024, 18:57 · Bug Reports, Herald

Jul 18 2024

pppery added a comment to D25618: Avoid search exception for calendar events when using localized time formats.

I think the behavior of not setting the timezone is probably correct, actually. GetFormattedDateFromParts below already constructs a date object again with the timezone set. So I think the timezone offset is being applied twice here.

Jul 18 2024, 18:28 · Calendar

Jun 21 2024

pppery added a project to T15854: "Undefined array key 1" exception when @task in PHPDoc is a single string: Diviner.

Jun 21 2024, 21:49 · Diviner

pppery added a project to T15860: Editing a Herald rule fails to display values of custom field: "Unknown Object (????)": Herald.

Jun 21 2024, 21:49 · Herald

pppery closed D25695: Add fallback languages for locale files.

Jun 21 2024, 17:10

pppery committed rARC0af89f7d323b: Add fallback languages for locale files.

Add fallback languages for locale files

Jun 21 2024, 17:10

Jun 20 2024

pppery added a comment to T15862: Some messages that support PLURAL are not detected as such by the i18n string extractor.

From an attempt I made to fix this before running out of motivation (this lists all parameters that vary on number in the US English translation but the i18n extractor thinks they don't)

WARNING  /applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php:269: missing PhutilNumber call?
WARNING  /applications/config/check/PhabricatorExtraConfigSetupCheck.php:72: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:58: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:73: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:316: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:321: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:347: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:390: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:397: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:524: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:578: missing PhutilNumber call?
WARNING  /applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php:74: missing PhutilNumber call?
WARNING  /applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php:80: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:36: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:48: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:78: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:92: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:39: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:51: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:81: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:95: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasCommitEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasCommitEdgeType.php:46: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:18: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:30: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:61: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:75: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:45: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:76: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:90: missing PhutilNumber call?
WARNING  /applications/differential/mail/DifferentialCreateMailReceiver.php:75: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:523: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:525: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:529: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:531: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:556: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:558: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:562: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:564: missing PhutilNumber call?
WARNING  /applications/differential/storage/DifferentialTransaction.php:593: missing PhutilNumber call?
WARNING  /applications/differential/storage/DifferentialTransaction.php:597: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasRevisionEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasRevisionEdgeType.php:46: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:45: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:76: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:90: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:22: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:64: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:78: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:25: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:37: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:67: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:81: missing PhutilNumber call?
WARNING  /applications/legalpad/edge/LegalpadObjectNeedsSignatureEdgeType.php:17: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:32: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:44: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:74: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:88: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:37: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:49: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:79: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:93: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:45: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:76: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:90: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasMockEdgeType.php:21: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasMockEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:45: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:76: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:90: missing PhutilNumber call?
WARNING  /applications/owners/xaction/PhabricatorOwnersPackageOwnersTransaction.php:54: missing PhutilNumber call?
WARNING  /applications/owners/xaction/PhabricatorOwnersPackageOwnersTransaction.php:60: missing PhutilNumber call?
WARNING  /applications/pholio/edge/PholioMockHasTaskEdgeType.php:21: missing PhutilNumber call?
WARNING  /applications/pholio/edge/PholioMockHasTaskEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/pholio/xaction/PholioImageFileTransaction.php:61: missing PhutilNumber call?
WARNING  /applications/pholio/xaction/PholioImageFileTransaction.php:67: missing PhutilNumber call?
WARNING  /applications/phortune/controller/account/PhortuneAccountOverviewController.php:116: missing PhutilNumber call?
WARNING  /applications/phortune/edge/PhortuneAccountHasMemberEdgeType.php:17: missing PhutilNumber call?
WARNING  /applications/phortune/edge/PhortuneAccountHasMemberEdgeType.php:29: missing PhutilNumber call?
WARNING  /applications/phortune/edge/PhortuneMerchantHasMemberEdgeType.php:17: missing PhutilNumber call?
WARNING  /applications/phortune/edge/PhortuneMerchantHasMemberEdgeType.php:29: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectMemberOfProjectEdgeType.php:22: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectMemberOfProjectEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:24: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:36: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:67: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:81: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:22: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:64: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:78: missing PhutilNumber call?
WARNING  /applications/project/storage/PhabricatorProjectTransaction.php:108: missing PhutilNumber call?
WARNING  /applications/project/storage/PhabricatorProjectTransaction.php:120: missing PhutilNumber call?
WARNING  /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:56: missing PhutilNumber call?
WARNING  /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:62: missing PhutilNumber call?
WARNING  /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:90: missing PhutilNumber call?
WARNING  /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:97: missing PhutilNumber call?
WARNING  /applications/repository/worker/PhabricatorRepositoryPushMailWorker.php:77: missing PhutilNumber call?
WARNING  /applications/repository/worker/PhabricatorRepositoryPushMailWorker.php:108: missing PhutilNumber call?
WARNING  /applications/subscriptions/engineextension/PhabricatorSubscriptionsCurtainExtension.php:98: missing PhutilNumber call?
WARNING  /applications/subscriptions/view/SubscriptionListStringBuilder.php:67: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasContributorEdgeType.php:22: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasContributorEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:21: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:63: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:77: missing PhutilNumber call?
WARNING  /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:38: missing PhutilNumber call?
WARNING  /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:39: missing PhutilNumber call?
WARNING  /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:44: missing PhutilNumber call?
WARNING  /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:55: missing PhutilNumber call?
WARNING  /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:56: missing PhutilNumber call?
WARNING  /applications/transactions/storage/PhabricatorApplicationTransaction.php:1042: missing PhutilNumber call?
WARNING  /applications/transactions/storage/PhabricatorApplicationTransaction.php:1053: missing PhutilNumber call?
WARNING  /infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php:140: missing PhutilNumber call?
WARNING  /infrastructure/edges/type/PhabricatorEdgeType.php:66: missing PhutilNumber call?
WARNING  /infrastructure/edges/type/PhabricatorEdgeType.php:78: missing PhutilNumber call?
WARNING  /infrastructure/edges/type/PhabricatorEdgeType.php:109: missing PhutilNumber call?
WARNING  /infrastructure/edges/type/PhabricatorEdgeType.php:123: missing PhutilNumber call?

Not all of these should be fixed in the obvious way, or even can be.

Jun 20 2024, 18:42 · Legalpad, Localization

pppery created T15863: Phorge doesn't seem to properly support gramatical gender.

Jun 20 2024, 18:11 · Localization

pppery created T15862: Some messages that support PLURAL are not detected as such by the i18n string extractor.

Jun 20 2024, 18:03 · Legalpad, Localization

pppery updated the diff for D25695: Add fallback languages for locale files.

Fix a typo

Jun 20 2024, 15:07

pppery added a comment to D25695: Add fallback languages for locale files.

Done that. I left the technically-redundant methods where I have a lengthy comment explaining why I return en_US, since I think it's helpful to explain why that is.

Jun 20 2024, 15:06

pppery updated the diff for D25695: Add fallback languages for locale files.

Don't make unnecessary whitespace changes

Jun 20 2024, 15:04

pppery updated the diff for D25695: Add fallback languages for locale files.

Set fallback locale in base class

Jun 20 2024, 15:02

pppery added a comment to D25695: Add fallback languages for locale files.

The current behavior if a fallback locale is not specified is to fallback to the proto-English string (English without applying pluralization). It probably does make sense, now that you bring it up, to fall back to en_US instead by default instead of doing that in every locale.

Jun 20 2024, 14:56

Jun 19 2024

pppery updated the diff for D25695: Add fallback languages for locale files.

Ce a comment

Jun 19 2024, 21:36

pppery added inline comments to D25695: Add fallback languages for locale files.

Jun 19 2024, 20:29

pppery updated the diff for D25695: Add fallback languages for locale files.

Fix lint

Jun 19 2024, 20:16

pppery requested review of D25695: Add fallback languages for locale files.

Jun 19 2024, 20:12

pppery created T15861: Support bidirectional fallback locales.

Jun 19 2024, 19:43 · Arcanist, Localization

Jun 12 2024

pppery claimed T15840: Don't give bad password advice when resetting password.

Jun 12 2024, 04:01

pppery changed the status of T15840: Don't give bad password advice when resetting password from Spite to Resolved by committing rP1bb7422662ac: Reword joke password reset email message.

Jun 12 2024, 03:59

pppery closed D25671: Reword joke password reset email message.

Jun 12 2024, 03:59

pppery committed rP1bb7422662ac: Reword joke password reset email message.

Reword joke password reset email message

Jun 12 2024, 03:59

Jun 8 2024

pppery added a project to T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated: PHP 8 support.

Jun 8 2024, 23:59 · Deprecation Notice, PHP 8 support

pppery added a project to T15757: Arcanist Test Result Parser Updates: Arcanist.

Jun 8 2024, 23:58 · Arcanist

pppery added a project to T15772: Task with graph issue won't show: Maniphest.

Jun 8 2024, 23:58 · Bug Reports, Maniphest

pppery added projects to T15790: Exception creating a "Diffusion Raw Commits" Dashboard query panel: Dashboards, Diffusion.

Jun 8 2024, 23:58 · Diffusion, Dashboards

pppery added a project to T15811: Search exception when AM/PM string is localized in Calendar application: Calendar.

Jun 8 2024, 23:57 · Localization, Bug Reports, Calendar

pppery added a project to T15843: Allow collapse and expand of workboard columns in mobile view: Workboard.

Jun 8 2024, 23:56 · Workboard

Jun 7 2024

pppery closed D25684: Remove PhutilPhtTestCase::getDateTranslations().

Jun 7 2024, 19:10

pppery committed rARCf7fcf31c7e23: Remove PhutilPhtTestCase::getDateTranslations().

Remove PhutilPhtTestCase::getDateTranslations()

Jun 7 2024, 19:10

pppery added a comment to D25684: Remove PhutilPhtTestCase::getDateTranslations().

No, it never was called anywhere. Read the HTML comment this commit deletes.

Jun 7 2024, 18:56

pppery updated the summary of D25684: Remove PhutilPhtTestCase::getDateTranslations().

Jun 7 2024, 16:57

pppery requested review of D25684: Remove PhutilPhtTestCase::getDateTranslations().

Jun 7 2024, 16:55

pppery added a comment to T15815: Make i18n string extraction ignore strings in test cases.

... but it turns out by concidence most of the date elements that are worth translating are already translatable from other references in the code:

Jun 7 2024, 04:33 · Localization

pppery added a comment to T15815: Make i18n string extraction ignore strings in test cases.

// The only purpose of this function is to provide a static list of
// translations which can come from PhutilTranslator::translateDate() to
// allow translation extractor getting them.

I seem to have a bad habit of doing things and realizing they were stupid or I had missed something weeks to months later.

Jun 7 2024, 03:12 · Localization

Jun 6 2024

pppery closed T15850: Typo in auth message when unlinking accounts as Resolved by committing rPd8cd959622da: Fix a leftover misspelled "Phabricator" reference.

Jun 6 2024, 14:37

pppery closed D25682: Fix a leftover misspelled "Phabricator" reference.

Jun 6 2024, 14:37

pppery committed rPd8cd959622da: Fix a leftover misspelled "Phabricator" reference.

Fix a leftover misspelled "Phabricator" reference

Jun 6 2024, 14:37

pppery added a project to T15851: Support proper pluralization in mock task activity: Bug Reports.

Jun 6 2024, 05:39 · Bug Reports

pppery renamed T15851: Support proper pluralization in mock task activity from Support proper PLURAL syntax in mocks to Support proper pluralization in mock task activity.

Jun 6 2024, 05:39 · Bug Reports

pppery created T15851: Support proper pluralization in mock task activity.

Jun 6 2024, 05:37 · Bug Reports

pppery added a comment to D25682: Fix a leftover misspelled "Phabricator" reference.

I would be find with turning this into "your PlatformSymbols::getPlatformServerName() account" instead if that's seen as clearer but I'm not convinced the platform is necessary here at all. Opinions on that welcome.

Jun 6 2024, 02:34

pppery requested review of D25682: Fix a leftover misspelled "Phabricator" reference.

Jun 6 2024, 02:27

pppery added a revision to T15850: Typo in auth message when unlinking accounts: D25682: Fix a leftover misspelled "Phabricator" reference.

Jun 6 2024, 02:27

pppery claimed T15850: Typo in auth message when unlinking accounts.

Jun 6 2024, 01:39

pppery updated the task description for T15850: Typo in auth message when unlinking accounts.

Jun 6 2024, 01:24

pppery created T15850: Typo in auth message when unlinking accounts.

Jun 6 2024, 01:24