In D25068#2771, @valerio.bozzolan wrote:Do you want an hand to land this nice feature?
(I will assume "yeah my friend" in 3 days)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Mar 27 2023
Mar 27 2023
valerio.bozzolan retitled D25068: Workboard: improve the Create Task link to mention the Project slug from Workboard: add Project slug to query param in Create Task action of column menu
valerio.bozzolan retitled D25068: Workboard: improve the Create Task link to mention the Project slug from Add project slug to tags query param in create action URLs on workboard column menus to Workboard: add Project slug to query param in Create Task action of column menu.
valerio.bozzolan added a comment to D25068: Workboard: improve the Create Task link to mention the Project slug.
valerio.bozzolan updated the task description for T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string.
valerio.bozzolan updated the task description for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
valerio.bozzolan updated the task description for T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string.
valerio.bozzolan updated the task description for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
valerio.bozzolan updated the task description for T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string.
valerio.bozzolan renamed T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo) from Fix Arcanist in PHP 8.2 to Fix Arcanist in PHP 8.2 (testing the Phorge repo).
valerio.bozzolan updated the task description for T15201: PHP 8.2: creation of dynamic property is deprecated.
valerio.bozzolan updated the task description for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
valerio.bozzolan renamed T15197: arc unit --everything: error "Creation of dynamic property is deprecated" from PHP 8.2: Creation of dynamic property is deprecated to arc unit --everything: error "Creation of dynamic property is deprecated".
valerio.bozzolan updated the diff for D25086: Ponder: strike code of resolved questions in query results.
add inline comment
valerio.bozzolan added inline comments to D25099: PHP 8.2: fix deprecated use of "parent" in callables.
valerio.bozzolan closed T15201: PHP 8.2: creation of dynamic property is deprecated, a subtask of T15198: PHP 8.2 deprecations fix strategies, as Resolved.
valerio.bozzolan updated the diff for D25100: PHP 8.2: fix deprecated creation of dynamic properties.
checkout master and cherry-pick from D25100
Mar 26 2023
Mar 26 2023
valerio.bozzolan added a comment to T15053: Develop the translation strategy for strings on the client `JX` side.
I think that, from the view model, we should be able to call something like this:
valerio.bozzolan triaged T15202: Show confirmation dialog also when closing tab if content changed as Wishlist priority.
Thanks @avivey honestly it was interesting and deeply connected to a scary PHP internal travel: if I understand correctly, "id" is considered a constant and expanded as the "id" string for backward compatibility reasons. Then, ${} expands that.
valerio.bozzolan updated the summary of D25100: PHP 8.2: fix deprecated creation of dynamic properties.
valerio.bozzolan closed T15196: PHP 8.2: using ${var} in strings is deprecated, a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
valerio.bozzolan closed T15196: PHP 8.2: using ${var} in strings is deprecated, a subtask of T15198: PHP 8.2 deprecations fix strategies, as Resolved.
Wow. Probably there was only one case. Let's stay ready to reopen, but probably we are OK.
valerio.bozzolan awarded D25098: PHP 8.2: fixes for deprecated use of ${var} in strings a Like token.
I have a feeling both of these can be blamed back to me...
valerio.bozzolan updated the test plan for D25099: PHP 8.2: fix deprecated use of "parent" in callables.
valerio.bozzolan updated the summary of D25084: Remarkup: avoid to open internal pages as external links (as default).
valerio.bozzolan updated the task description for T15200: PHP 8.2: Use of "parent" in callables is deprecated.
valerio.bozzolan requested review of D25100: PHP 8.2: fix deprecated creation of dynamic properties.
valerio.bozzolan updated the task description for T15201: PHP 8.2: creation of dynamic property is deprecated.
valerio.bozzolan raised a concern with rPb8a515cb29d8: Bring new password validation into AuthPasswordEngine.
valerio.bozzolan triaged T15201: PHP 8.2: creation of dynamic property is deprecated as High priority.
valerio.bozzolan updated the test plan for D25099: PHP 8.2: fix deprecated use of "parent" in callables.
valerio.bozzolan added inline comments to D25099: PHP 8.2: fix deprecated use of "parent" in callables.
valerio.bozzolan updated the test plan for D25099: PHP 8.2: fix deprecated use of "parent" in callables.
valerio.bozzolan moved T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4 from Backlog to Epic on the PHP 8.2 support board.
valerio.bozzolan moved T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo) from Backlog to Epic on the PHP 8.2 support board.
valerio.bozzolan renamed T15198: PHP 8.2 deprecations fix strategies from Handle deprecations of PHP 8.2 to PHP 8.2 deprecations fix strategies.
valerio.bozzolan updated the task description for T15200: PHP 8.2: Use of "parent" in callables is deprecated.
valerio.bozzolan retitled D25030: Fix PHP 8.1 and 8.2 incompatibilities mostly from Fix PHP 8.1 incompatibilities mostly
valerio.bozzolan added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
I added that sub-task since it is a bit hypocritical for us to ask why many people don't use Arcanist... if Arcanist does not support any official stable version of PHP.
valerio.bozzolan requested review of D25098: PHP 8.2: fixes for deprecated use of ${var} in strings.
It seems Rector.php has not an automatic rule for that.
valerio.bozzolan added inline comments to D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.
valerio.bozzolan added inline comments to D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.
valerio.bozzolan updated the diff for D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.
simplify even more
valerio.bozzolan updated the diff for D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.
try to make the diff even more simple
valerio.bozzolan updated the summary of D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.
valerio.bozzolan added a comment to T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string.
I renamed the proposal from configString() to configStr() so that I do not break the 80 characters lint limitation ihih
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0