Page MenuHomePhorge
Feed Advanced Search

Thu, May 29

aklapper added a revision to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set: D26036: Fix PHP 8.1 "preg_replace(null)" exception in PhabricatorEditorURIEngine.php.
Thu, May 29, 21:33 · PHP 8 support, Deprecation Notice
aklapper added a comment to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set.

Looking at src/applications/repository/storage/PhabricatorRepository.php I see stuff like $has_shortname = ($this->getRepositorySlug() !== null); so it seems that a repository "slug" is what the UI calls a "short name". That's also seconded by code in DiffusionRepositoryEditEngine.

Thu, May 29, 21:22 · PHP 8 support, Deprecation Notice
aklapper added a comment to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set.

Copying from Q182:

PhabricatorEditorURIEngine.php:283, occurrences: 4
preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
arcanist(head=stable, ref.master=989690868513, ref.stable=05abd055019c), libphremoteuser(head=clarion, ref.master=944307decd9c, ref.clarion=d0da6c048bd5), phorge(head=stable, custom=4), translations(head=wmf/stable, ref.wmf/stable=76bb64361cec)
#0 preg_replace(string, string, NULL) called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:283]
#1 PhabricatorEditorURIEngine::escapeToken(NULL) called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:144]
#2 PhabricatorEditorURIEngine::newURITokensForRepository() called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:128]
#3 PhabricatorEditorURIEngine::getURITokensForRepository(string) called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:84]
#4 PhabricatorEditorURIEngine::getURITokensForPath(string) called at [<phorge>/src/applications/differential/view/DifferentialChangesetDetailView.php:371]
#5 DifferentialChangesetDetailView::getEditorURITemplate() called at [<phorge>/src/applications/differential/view/DifferentialChangesetDetailView.php:272]
#6 DifferentialChangesetDetailView::render() called at [<phorge>/src/applications/differential/view/DifferentialChangesetListView.php:240]
#7 DifferentialChangesetListView::render() called at [<phorge>/src/view/AphrontView.php:222]
#8 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115]
#9 phutil_escape_html(DifferentialChangesetListView) called at [<phorge>/src/infrastructure/markup/render.php:139]
#10 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:139]
#11 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:97]
#12 phutil_tag(string, array, array) called at [<phorge>/src/view/phui/PHUITwoColumnView.php:236]
#13 PHUITwoColumnView::buildFooter() called at [<phorge>/src/view/phui/PHUITwoColumnView.php:123]
#14 PHUITwoColumnView::getTagContent() called at [<phorge>/src/view/AphrontTagView.php:161]
#15 AphrontTagView::render() called at [<phorge>/src/view/AphrontView.php:222]
#16 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115]
#17 phutil_escape_html(PHUITwoColumnView) called at [<phorge>/src/infrastructure/markup/render.php:139]
#18 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:139]
#19 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:97]
#20 phutil_tag(string, array, array) called at [<phorge>/src/view/formation/PHUIFormationContentView.php:13]
#21 PHUIFormationContentView::render() called at [<phorge>/src/view/AphrontView.php:222]
#22 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115]
#23 phutil_escape_html(PHUIFormationContentView) called at [<phorge>/src/infrastructure/markup/render.php:139]
#24 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:97]
#25 phutil_tag(string, array, array) called at [<phorge>/src/view/formation/PHUIFormationView.php:58]
#26 PHUIFormationView::render() called at [<phorge>/src/view/AphrontView.php:222]
#27 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115]
#28 phutil_escape_html(PHUIFormationView) called at [<phorge>/src/infrastructure/markup/render.php:171]
#29 phutil_implode_html(string, array) called at [<phorge>/src/view/page/PhabricatorBarePageView.php:58]
#30 PhabricatorBarePageView::willRenderPage() called at [<phorge>/src/view/page/PhabricatorStandardPageView.php:217]
#31 PhabricatorStandardPageView::willRenderPage() called at [<phorge>/src/view/page/AphrontPageView.php:46]
#32 AphrontPageView::render() called at [<phorge>/src/view/page/PhabricatorStandardPageView.php:918]
#33 PhabricatorStandardPageView::produceAphrontResponse() called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:724]
#34 AphrontApplicationConfiguration::produceResponse(AphrontRequest, PhabricatorStandardPageView) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:299]
#35 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203]
#36 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]
Thu, May 29, 20:31 · PHP 8 support, Deprecation Notice
aklapper added a parent task for T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set: T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4.
Thu, May 29, 09:21 · PHP 8 support, Deprecation Notice

May 9 2025

valerio.bozzolan added a comment to T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4).

Thanks. I pinpoint also here your super-relevant extra details: https://we.phorge.it/D25887#26924

May 9 2025, 09:25 · Deprecation Notice, PHP 8 support, Bug Reports
aklapper closed T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4) as Resolved by committing rP6619fef2ff97: Remove use of deprecated E_STRICT PHP constant.
May 9 2025, 09:23 · Deprecation Notice, PHP 8 support, Bug Reports

Apr 24 2025

aklapper closed T15829: Deprecation notice @ PhabricatorStandardPageView.php:630 (missing User-Agent HTTP Header) as Resolved by committing rP372316c99836: Fix PHP 8.1 "preg_match(null)" exception for missing User-Agent HTTP Header.
Apr 24 2025, 06:08 · PHP 8 support, Deprecation Notice

Apr 22 2025

aklapper renamed T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set from Deprecation notice at PhabricatorEditorURIEngine.php:283 to Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set.
Apr 22 2025, 08:10 · PHP 8 support, Deprecation Notice
aklapper renamed T15829: Deprecation notice @ PhabricatorStandardPageView.php:630 (missing User-Agent HTTP Header) from Deprecation notice @ PhabricatorStandardPageView.php:630 to Deprecation notice @ PhabricatorStandardPageView.php:630 (missing User-Agent HTTP Header).
Apr 22 2025, 08:09 · PHP 8 support, Deprecation Notice

Apr 21 2025

connorgurney renamed T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4) from `arc unit`: Constant E_STRICT is deprecated (with PHP 8.4) to `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4).
Apr 21 2025, 23:50 · Deprecation Notice, PHP 8 support, Bug Reports
connorgurney added a comment to T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4).

Can confirm that this appears on all commands rather than just unit, so have renamed the task accordingly.

Apr 21 2025, 23:50 · Deprecation Notice, PHP 8 support, Bug Reports

Apr 5 2025

mainframe98 removed a revision from T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4): D25946: Remove support for PHP mysql extension.
Apr 5 2025, 12:07 · Deprecation Notice, PHP 8 support, Bug Reports
mainframe98 added a revision to T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4): D25946: Remove support for PHP mysql extension.
Apr 5 2025, 12:03 · Deprecation Notice, PHP 8 support, Bug Reports

Apr 2 2025

aklapper updated subscribers of T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated.

Patch based on my understanding of taavi's comments in T15963 (as I fail to set up an LDAP server locally):

diff --git a/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php b/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php
index 14047c1761..e25659a4aa 100644
--- a/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php
+++ b/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php
@@ -305,7 +305,16 @@ final class PhutilLDAPAuthAdapter extends PhutilAuthAdapter {
           'port' => $this->port,
         ));
Apr 2 2025, 21:43 · Deprecation Notice, PHP 8 support

Mar 1 2025

aklapper added a parent task for T15829: Deprecation notice @ PhabricatorStandardPageView.php:630 (missing User-Agent HTTP Header): T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4.
Mar 1 2025, 19:34 · PHP 8 support, Deprecation Notice

Feb 17 2025

taavi added a comment to T15976: Deprecate id() function: no longer necessary since PHP 5.4.0.

Note that (clone $foo)->bar() is still invalid so you need to use id(clone $foo)->bar().

Feb 17 2025, 11:56 · Deprecation Notice
aklapper added a revision to T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4): D25887: Remove use of deprecated E_STRICT PHP constant.
Feb 17 2025, 11:49 · Deprecation Notice, PHP 8 support, Bug Reports
aklapper added a revision to T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4): D25886: Remove use of deprecated E_STRICT PHP constant.
Feb 17 2025, 11:37 · Deprecation Notice, PHP 8 support, Bug Reports
aklapper added a comment to T15976: Deprecate id() function: no longer necessary since PHP 5.4.0.

grep -r " id(" --include=*.php . | wc -l gives a whopping 11220 results.
Would we accept a patch if I cooked up one? :)

Feb 17 2025, 10:36 · Deprecation Notice

Feb 15 2025

taavi added a project to T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4): Deprecation Notice.
Feb 15 2025, 07:42 · Deprecation Notice, PHP 8 support, Bug Reports

Feb 10 2025

aklapper merged task T15934: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:16 into T15930: PHP 8.1 "strlen(null)" exception in HTTPFutureHTTPResponseStatus.
Feb 10 2025, 19:31 · Arcanist, PHP 8 support, Deprecation Notice
aklapper added a revision to T15829: Deprecation notice @ PhabricatorStandardPageView.php:630 (missing User-Agent HTTP Header): D25868: Fix PHP 8.1 "preg_match(null)" exception for missing User-Agent HTTP Header.
Feb 10 2025, 19:30 · PHP 8 support, Deprecation Notice
aklapper moved T15829: Deprecation notice @ PhabricatorStandardPageView.php:630 (missing User-Agent HTTP Header) from Deprecation Notices to PHP 8.1 on the PHP 8 support board.
Feb 10 2025, 19:29 · PHP 8 support, Deprecation Notice

Dec 28 2024

Cigaryno moved T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set from Backlog to Deprecation Notices on the PHP 8 support board.
Dec 28 2024, 18:21 · PHP 8 support, Deprecation Notice
Cigaryno moved T15829: Deprecation notice @ PhabricatorStandardPageView.php:630 (missing User-Agent HTTP Header) from Backlog to Deprecation Notices on the PHP 8 support board.
Dec 28 2024, 18:21 · PHP 8 support, Deprecation Notice
Cigaryno moved T15934: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:16 from Backlog to Deprecation Notices on the PHP 8 support board.
Dec 28 2024, 18:21 · Arcanist, PHP 8 support, Deprecation Notice
Cigaryno closed Q141: LotusLinkManiphestCustomField.php:258, occurrences: 1 as resolved.
Dec 28 2024, 16:22 · Deprecation Notice

Dec 19 2024

Cigaryno added a project to T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated: Deprecation Notice.
Dec 19 2024, 10:46 · Deprecation Notice, PHP 8 support

Dec 18 2024

Cigaryno moved T15934: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:16 from Backlog to PHP 8 Support on the Arcanist board.
Dec 18 2024, 15:35 · Arcanist, PHP 8 support, Deprecation Notice

Dec 17 2024

valerio.bozzolan created T15976: Deprecate id() function: no longer necessary since PHP 5.4.0.
Dec 17 2024, 09:44 · Deprecation Notice

Aug 29 2024

revi added projects to T15934: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:16: Deprecation Notice, PHP 8 support, Arcanist.
Aug 29 2024, 15:34 · Arcanist, PHP 8 support, Deprecation Notice

Jul 2 2024

TychoTa updated the question details for Q141: LotusLinkManiphestCustomField.php:258, occurrences: 1.
Jul 2 2024, 12:21 · Deprecation Notice
TychoTa asked Q141: LotusLinkManiphestCustomField.php:258, occurrences: 1.
Jul 2 2024, 12:21 · Deprecation Notice

Jun 19 2024

revi added a comment to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set.
$ git show
commit d519f75dfdee61bb109468aa708c47f53f3e5128 (HEAD -> stable, origin/stable)
Author: Mark Jervelund <EMAIL-REDACTED>
Date:   Mon Feb 12 11:51:24 2024 +0100
Jun 19 2024, 14:05 · PHP 8 support, Deprecation Notice
aklapper added a comment to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set.

@revi: Could you please double-check and confirm that the line 144 in <phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php is
'n' => $this->escapeToken($repository->getRepositorySlug()),
in your installation? Thanks in advance!

Jun 19 2024, 13:52 · PHP 8 support, Deprecation Notice

May 14 2024

revi triaged T15829: Deprecation notice @ PhabricatorStandardPageView.php:630 (missing User-Agent HTTP Header) as Normal priority.
May 14 2024, 16:39 · PHP 8 support, Deprecation Notice

May 11 2024

aklapper added a revision to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set: D25635: Fix PHP 8.1 "preg_replace(null)" exception in PhabricatorEditorURIEngine.php.
May 11 2024, 20:51 · PHP 8 support, Deprecation Notice
revi triaged T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set as Normal priority.
May 11 2024, 17:05 · PHP 8 support, Deprecation Notice

May 10 2024

aklapper closed T15821: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:24 as Resolved by committing rARC7f28d7266f81: Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type.
May 10 2024, 16:13 · Arcanist, Deprecation Notice
aklapper added a revision to T15821: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:24: D25632: Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type.
May 10 2024, 10:04 · Arcanist, Deprecation Notice
revi created T15821: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:24.
May 10 2024, 07:27 · Arcanist, Deprecation Notice

May 2 2024

aklapper closed T15808: Deprecation notice @ PhabricatorPasteLanguageTransaction.php:17 as Resolved by committing rP279ed1ee7661: Fix PHP 8.1 "strlen(null)" exception in PhabricatorPasteLanguageTransaction.php.
May 2 2024, 08:28 · Deprecation Notice
aklapper closed T15807: Deprecation notice @ PhabricatorStandardCustomFieldLink.php:24 as Resolved by committing rP488960ae7a80: Fix PHP 8.1 "strlen(null)" exception in PhabricatorStandardCustomFieldLink.php.
May 2 2024, 08:26 · Deprecation Notice

May 1 2024

aklapper added a revision to T15808: Deprecation notice @ PhabricatorPasteLanguageTransaction.php:17: D25611: Fix PHP 8.1 "strlen(null)" exception in PhabricatorPasteLanguageTransaction.php.
May 1 2024, 15:48 · Deprecation Notice
aklapper added a revision to T15807: Deprecation notice @ PhabricatorStandardCustomFieldLink.php:24: D25610: Fix PHP 8.1 "strlen(null)" exception in PhabricatorStandardCustomFieldLink.php.
May 1 2024, 15:40 · Deprecation Notice
aklapper added a comment to T15808: Deprecation notice @ PhabricatorPasteLanguageTransaction.php:17.

Oh neat, I see. Thanks!

May 1 2024, 15:33 · Deprecation Notice
revi added a comment to T15808: Deprecation notice @ PhabricatorPasteLanguageTransaction.php:17.

That is, what I get from setup issues at https://issuetracker.revi.xyz/config/issue/deprecations/ is to report it:

May 1 2024, 15:15 · Deprecation Notice
revi added a comment to T15807: Deprecation notice @ PhabricatorStandardCustomFieldLink.php:24.

For completeness: Cf. T15808#17058

May 1 2024, 15:11 · Deprecation Notice
revi added a comment to T15808: Deprecation notice @ PhabricatorPasteLanguageTransaction.php:17.

Also, phorge version and arcanist version is included in line 2.

May 1 2024, 15:07 · Deprecation Notice
aklapper added a comment to T15807: Deprecation notice @ PhabricatorStandardCustomFieldLink.php:24.

@revi: Hi, could you please provide a list of steps to reproduce, if possible, and always exact Phorge version info? Thanks!

May 1 2024, 14:18 · Deprecation Notice
aklapper added a comment to T15808: Deprecation notice @ PhabricatorPasteLanguageTransaction.php:17.

@revi: Hi, could you please provide a list of steps to reproduce, if possible, and always exact Phorge version info? Thanks!

May 1 2024, 14:17 · Deprecation Notice
revi created T15808: Deprecation notice @ PhabricatorPasteLanguageTransaction.php:17.
May 1 2024, 10:10 · Deprecation Notice
revi created T15807: Deprecation notice @ PhabricatorStandardCustomFieldLink.php:24.
May 1 2024, 10:00 · Deprecation Notice

Apr 14 2024

bekay updated the question details for Q126: 5 Deprecation Notices in PhabricatorStandardPageView.php.
Apr 14 2024, 09:34 · Deprecation Notice
bekay updated Q126: 5 Deprecation Notices in PhabricatorStandardPageView.php from 5 Deprecation Notices PhabricatorStandardPageView to 5 Deprecation Notices in PhabricatorStandardPageView.php.
Apr 14 2024, 09:03 · Deprecation Notice
bekay asked Q126: 5 Deprecation Notices in PhabricatorStandardPageView.php.
Apr 14 2024, 08:13 · Deprecation Notice

Mar 8 2024

valerio.bozzolan updated Q112: Deprecation Notice from PhrictionRemarkupRule.php:194 from Deprecation Notice to Deprecation Notice from PhrictionRemarkupRule.php:194.
Mar 8 2024, 10:51 · Deprecation Notice
valerio.bozzolan added a comment to Q112: Deprecation Notice from PhrictionRemarkupRule.php:194.

(Marking as Resolved thanks to the mentioned patch - feel free to reopen and thanks)

Mar 8 2024, 10:51 · Deprecation Notice
valerio.bozzolan closed Q112: Deprecation Notice from PhrictionRemarkupRule.php:194 as resolved.
Mar 8 2024, 10:50 · Deprecation Notice

Feb 23 2024

bekay asked Q112: Deprecation Notice from PhrictionRemarkupRule.php:194.
Feb 23 2024, 10:11 · Deprecation Notice

Nov 24 2023

avivey created Deprecation Notice.
Nov 24 2023, 18:16