Page MenuHomePhorge
Feed All Stories

Mon, Jun 2

aklapper added a comment to D26055: Restrict maximum number of search tokens per query to 16.

Looks like https://we.phorge.it/source/phorge/browse/master/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php$2118-2125 and https://we.phorge.it/source/phorge/browse/master/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php$2499-2506 already do this silently but only for JOIN clauses.

Mon, Jun 2, 14:28
avm99963 asked Q183: Possible DOS in Phorge instances.
Mon, Jun 2, 11:54 · Security
aklapper added a comment to T16090: Add visualization support on large monitors.

Hi, please explain specifically what "support for large monitors" means to you.
Large monitors are "supported" as all the content on a Phorge page is correctly displayed, layouted, readable on large monitors, as your screenshot proves. :)

Mon, Jun 2, 07:41 · Feature Requests, UX
vabocharov added a comment to T16090: Add visualization support on large monitors.

Hi!
I agree that this is not a problem and it does not prevent me from explicitly using the features of the service, but for convenience, it would be good if there was support for large monitors.
Yes, it is possible to use a browser that does not cover the entire width of the monitor, but this is not very convenient for me personally, since other sites support such a diagonal of the monitor, which allows me to better read and write texts, code, and so on.
If you think that it is not worth adding support for such a diagonal, then I agree, since so far few people use such large diagonals. Personally, it wouldn't hurt for me to use phorge on my server.

Mon, Jun 2, 07:13 · Feature Requests, UX
aklapper added a comment to T16090: Add visualization support on large monitors.

Hi, could you please describe actual problems due to the current layout? Free space is not an issue per-se, for example limiting the content width makes sense.
I'm also a bit wondering why you would put/use the browser full screen when having such a ratio?

Mon, Jun 2, 06:59 · Feature Requests, UX
vabocharov attached a referenced file: F3981592: image.png.
Mon, Jun 2, 05:31 · Feature Requests, UX
vabocharov created T16090: Add visualization support on large monitors.
Mon, Jun 2, 05:31 · Feature Requests, UX

Sun, Jun 1

aklapper updated the task description for T16089: Query errors are displayed outside of viewport.
Sun, Jun 1, 21:28
aklapper added a comment to T16089: Query errors are displayed outside of viewport.
diff --git a/src/view/phui/PHUIObjectBoxView.php b/src/view/phui/PHUIObjectBoxView.php
index dce9d57568..13a0a3d061 100644
--- a/src/view/phui/PHUIObjectBoxView.php
+++ b/src/view/phui/PHUIObjectBoxView.php
@@ -318,6 +318,10 @@ final class PHUIObjectBoxView extends AphrontTagView {
       $lists,
       $this->table,
       $pager,
+      // When the anchor link scrolled us below the $showhide search parameters
+      // box, repeat the error message hidden and unseen at the top of the page
+      ($this->showHideOpen == true ? $this->formErrors : null),
       $this->renderChildren(),
     );

^ This would simply be ugly repeating of the error message below the search params box on http://phorge.localhost/maniphest/query/advanced/.
For testing the patch behavior with a results list, replace the line
($this->showHideOpen == true ? $this->formErrors : null),
with
($this->showHideOpen == true ? $header : null),

Sun, Jun 1, 21:18
aklapper created T16089: Query errors are displayed outside of viewport.
Sun, Jun 1, 21:16
aklapper requested review of D26055: Restrict maximum number of search tokens per query to 16.
Sun, Jun 1, 18:18
aklapper added a revision to T15831: Long search query can trigger raw "Too many tables; MariaDB can only use 61 tables in a join": D26055: Restrict maximum number of search tokens per query to 16.
Sun, Jun 1, 18:18
aklapper updated the summary of D26054: a11y: Add lang attribute to <html> element.
Sun, Jun 1, 14:30
aklapper added a revision to T16072: Accessibility improvements (June 2025): D26054: a11y: Add lang attribute to <html> element.
Sun, Jun 1, 14:30 · Accessibility
aklapper updated the summary of D26053: a11y: Do not mark top bar notifications area as aria-hidden.
Sun, Jun 1, 14:30
aklapper added a revision to T16072: Accessibility improvements (June 2025): D26053: a11y: Do not mark top bar notifications area as aria-hidden.
Sun, Jun 1, 14:30 · Accessibility
aklapper updated the summary of D26052: a11y: Set aria-label attribute for PHUIListItemView Edit links in task lists.
Sun, Jun 1, 14:30
aklapper added a revision to T16072: Accessibility improvements (June 2025): D26052: a11y: Set aria-label attribute for PHUIListItemView Edit links in task lists.
Sun, Jun 1, 14:30 · Accessibility
aklapper updated the summary of D26051: a11y: Set aria-label for comment action options dropdown.
Sun, Jun 1, 14:30
aklapper added a revision to T16072: Accessibility improvements (June 2025): D26051: a11y: Set aria-label for comment action options dropdown.
Sun, Jun 1, 14:30 · Accessibility
aklapper updated the summary of D26050: a11y: Set project workboard button tooltips as aria-label.
Sun, Jun 1, 14:30
aklapper added a revision to T16072: Accessibility improvements (June 2025): D26050: a11y: Set project workboard button tooltips as aria-label.
Sun, Jun 1, 14:30 · Accessibility
aklapper added a revision to T16072: Accessibility improvements (June 2025): D26049: a11y: Add alt text to main picture on profile page.
Sun, Jun 1, 14:30 · Accessibility
aklapper updated the summary of D26049: a11y: Add alt text to main picture on profile page.
Sun, Jun 1, 14:30
aklapper updated the summary of D26048: a11y: Add aria-label to mini badges below user avatars.
Sun, Jun 1, 14:30
aklapper added a revision to T16072: Accessibility improvements (June 2025): D26048: a11y: Add aria-label to mini badges below user avatars.
Sun, Jun 1, 14:30 · Accessibility
aklapper added a revision to T16072: Accessibility improvements (June 2025): D26047: a11y: Add "title" to <a> tags of PHUIObjectItemView images.
Sun, Jun 1, 14:30 · Accessibility
aklapper updated the summary of D26047: a11y: Add "title" to <a> tags of PHUIObjectItemView images.
Sun, Jun 1, 14:30
aklapper added a revision to T16072: Accessibility improvements (June 2025): D26046: a11y: Add aria-label to calendar date picker button.
Sun, Jun 1, 14:30 · Accessibility
aklapper updated the summary of D26046: a11y: Add aria-label to calendar date picker button.
Sun, Jun 1, 14:30
aklapper added a revision to T16072: Accessibility improvements (June 2025): D26045: a11y: Set textarea name parameter also as aria-label.
Sun, Jun 1, 14:30 · Accessibility
aklapper updated the summary of D26045: a11y: Set textarea name parameter also as aria-label.
Sun, Jun 1, 14:30
aklapper added a revision to T16072: Accessibility improvements (June 2025): D26044: a11y: Add aria-label to global search field in top bar.
Sun, Jun 1, 14:30 · Accessibility
aklapper updated the summary of D26044: a11y: Add aria-label to global search field in top bar.
Sun, Jun 1, 14:30
chris accepted D26047: a11y: Add "title" to <a> tags of PHUIObjectItemView images.
Sun, Jun 1, 13:41
chris accepted D26046: a11y: Add aria-label to calendar date picker button.
Sun, Jun 1, 13:40
chris accepted D26045: a11y: Set textarea name parameter also as aria-label.
Sun, Jun 1, 13:40
chris accepted D26044: a11y: Add aria-label to global search field in top bar.
Sun, Jun 1, 13:39
chris accepted D26048: a11y: Add aria-label to mini badges below user avatars.
Sun, Jun 1, 13:38
chris accepted D26049: a11y: Add alt text to main picture on profile page.
Sun, Jun 1, 13:38
chris accepted D26050: a11y: Set project workboard button tooltips as aria-label.
Sun, Jun 1, 13:37
chris accepted D26051: a11y: Set aria-label for comment action options dropdown.
Sun, Jun 1, 13:36
chris accepted D26053: a11y: Do not mark top bar notifications area as aria-hidden.
Sun, Jun 1, 13:35
chris accepted D26052: a11y: Set aria-label attribute for PHUIListItemView Edit links in task lists.
Sun, Jun 1, 13:34
chris accepted D26054: a11y: Add lang attribute to <html> element.
Sun, Jun 1, 13:34
aklapper requested review of D26054: a11y: Add lang attribute to <html> element.
Sun, Jun 1, 11:47
aklapper requested review of D26053: a11y: Do not mark top bar notifications area as aria-hidden.
Sun, Jun 1, 11:44
aklapper requested review of D26052: a11y: Set aria-label attribute for PHUIListItemView Edit links in task lists.
Sun, Jun 1, 11:42
aklapper requested review of D26051: a11y: Set aria-label for comment action options dropdown.
Sun, Jun 1, 11:39
aklapper requested review of D26050: a11y: Set project workboard button tooltips as aria-label.
Sun, Jun 1, 11:37
aklapper requested review of D26049: a11y: Add alt text to main picture on profile page.
Sun, Jun 1, 11:35
aklapper requested review of D26048: a11y: Add aria-label to mini badges below user avatars.
Sun, Jun 1, 11:33
aklapper requested review of D26047: a11y: Add "title" to <a> tags of PHUIObjectItemView images.
Sun, Jun 1, 11:29
aklapper requested review of D26046: a11y: Add aria-label to calendar date picker button.
Sun, Jun 1, 11:26
aklapper requested review of D26045: a11y: Set textarea name parameter also as aria-label.
Sun, Jun 1, 11:24
aklapper requested review of D26044: a11y: Add aria-label to global search field in top bar.
Sun, Jun 1, 11:22
aklapper closed D26042: More Search-related PhpDoc additions.
Sun, Jun 1, 11:07
aklapper committed rPe410020f78f7: More Search-related PhpDoc additions.
Sun, Jun 1, 11:07
aklapper added a comment to T16072: Accessibility improvements (June 2025).

Before and after Chromium Lighthouse a11y result comparison of some Phorge pages for patches I'm going to attach.
(Goodhart's Law applies, as with any misguiding incentives.)

Sun, Jun 1, 11:02 · Accessibility
valerio.bozzolan accepted D26042: More Search-related PhpDoc additions.

More docs yuum

Sun, Jun 1, 10:04
aklapper requested review of D26043: Correct Conduit project.search color result for milestones.
Sun, Jun 1, 09:47
aklapper added a revision to T16088: Conduit's project.search returns wrong color for milestones: D26043: Correct Conduit project.search color result for milestones.
Sun, Jun 1, 09:47
aklapper created T16088: Conduit's project.search returns wrong color for milestones.
Sun, Jun 1, 09:42
aklapper edited the content of Next Up.
Sun, Jun 1, 08:12
aklapper closed T16081: Warn users that adding a second Multi-Factor Auth will require both instead of choosing one of them as Resolved by committing rPa7f94af9cf5b: Explain consequences when adding second Multi-Factor Auth.
Sun, Jun 1, 08:10
aklapper closed D26028: Explain consequences when adding second Multi-Factor Auth.
Sun, Jun 1, 08:10
aklapper committed rPa7f94af9cf5b: Explain consequences when adding second Multi-Factor Auth.
Sun, Jun 1, 08:10

Sat, May 31

aklapper added a comment to D26035: Remove unused functions in PhabricatorFulltextToken.

Also nothing seems to use these functions?:

[acko@fedora phorge]$ grep -r compileLiteralQuery .
./phorge/src/applications/search/compiler/__tests__/PhutilSearchQueryCompilerTestCase.php:          $literal_query = $compiler->compileLiteralQuery($tokens);
./phorge/src/applications/search/compiler/PhutilSearchQueryCompiler.php:  public function compileLiteralQuery(array $tokens) {
[acko@fedora phorge]$ grep -r compileStemmedQuery .
./phorge/src/applications/search/compiler/__tests__/PhutilSearchQueryCompilerTestCase.php:          $stemmed_query = $compiler->compileStemmedQuery($tokens);
./phorge/src/applications/search/compiler/PhutilSearchQueryCompiler.php:  public function compileStemmedQuery(array $tokens) {
Sat, May 31, 22:39
aklapper renamed T16072: Accessibility improvements (June 2025) from Accessibility improvements (May 2025) to Accessibility improvements (June 2025).
Sat, May 31, 21:58 · Accessibility
aklapper edited the content of Next Up.
Sat, May 31, 21:57
aklapper edited the content of Next Up.
Sat, May 31, 21:55
aklapper edited the content of Next Up.
Sat, May 31, 21:52
aklapper closed D26031: Allow using PCRE's just-in-time compilation.
Sat, May 31, 21:52
aklapper closed T16084: Stop disabling pcre.jit by default as Resolved by committing rARCc739de1ef2f5: Allow using PCRE's just-in-time compilation.
Sat, May 31, 21:52
aklapper committed rARCc739de1ef2f5: Allow using PCRE's just-in-time compilation.
Sat, May 31, 21:52
aklapper requested review of D26042: More Search-related PhpDoc additions.
Sat, May 31, 21:33
aklapper accepted D26039: LiskDAO::getConfiguration return typing.

Nice find. Applying this patch removes about 250 errors in phpstan output here.

Sat, May 31, 13:33
valerio.bozzolan added a comment to D26040: Add missing ArcanistWorkflow::runWorkflow method.

Keeping it protected will throw Protected method PhageExecWorkflow::runWorkflow() overriding public method ArcanistWorkflow::runWorkflow() should also be public.

Sat, May 31, 13:02
aklapper accepted D26040: Add missing ArcanistWorkflow::runWorkflow method.

Running phpstan analyse, before this patch I get Call to an undefined method ArcanistWorkflow::runWorkflow(), after this patch I get Method ArcanistWorkflow::runWorkflow() invoked with 1 parameter, 0 required, both in src/workflow/ArcanistWorkflow.php:227. That looks like an improvement indeed.

Sat, May 31, 11:56
valerio.bozzolan added a comment to D26040: Add missing ArcanistWorkflow::runWorkflow method.

(This seems nice) Small question: Does it still work for you keeping the method as protected instead of public?

Sat, May 31, 11:19

Fri, May 30

amybones requested review of D26041: Fix ArcanistWorkflow::shouldRequireCleanUntrackedFiles.
Fri, May 30, 23:48
amybones updated the diff for D26040: Add missing ArcanistWorkflow::runWorkflow method.

Get rid of coverage errors :)

Fri, May 30, 23:40
amybones requested review of D26040: Add missing ArcanistWorkflow::runWorkflow method.
Fri, May 30, 23:37
amybones requested review of D26039: LiskDAO::getConfiguration return typing.
Fri, May 30, 23:11
aklapper updated aklapper.
Fri, May 30, 22:05
aklapper added a comment to D26037: Add phpDoc to PhabricatorCursorPagedPolicyAwareQuery.

Yes to the idea however a related elephant in the room (IMHO) are those non-standard types like list or map or wild being replaced, no clue if that has any effects on...something™ (Diviner docs? Code?) as I haven't managed to understand the consequences of code in https://we.phorge.it/source/arcanist/browse/master/src/parser/PhutilTypeSpec.php yet. (Technically speaking map and list seem to be just arrays, indeed.)

Fri, May 30, 22:01
amybones requested review of D26038: phpDoc PhabricatorApplicationQuery.
Fri, May 30, 21:55
aklapper updated the summary of D26037: Add phpDoc to PhabricatorCursorPagedPolicyAwareQuery.
Fri, May 30, 21:55
aklapper closed D26034: Fix PHP 8.1 "strlen(null)" exception in Client ID handling of PhabricatorOAuthServerTokenController.
Fri, May 30, 21:12
aklapper committed rP0c34164c8bf9: Fix PHP 8.1 "strlen(null)" exception in Client ID handling of….
Fri, May 30, 21:12
amybones added a comment to D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.

This isn't important, it just seems like this is a nice in-context place to leave this information :)

Fri, May 30, 20:45
amybones updated the diff for D26037: Add phpDoc to PhabricatorCursorPagedPolicyAwareQuery.

Use R[] because the keys may not be sequential.

Fri, May 30, 20:31
amybones added a comment to D26037: Add phpDoc to PhabricatorCursorPagedPolicyAwareQuery.

Hmm.. clearly I need to set xdebug.mode correctly, but I'm not sure why it wasn't. It's been fine before.

Fri, May 30, 20:20
amybones requested review of D26037: Add phpDoc to PhabricatorCursorPagedPolicyAwareQuery.
Fri, May 30, 20:06
jasonrumney added a comment to Q182: Deprecation warnings with PHP 8.3.

Correct, my instance is running the current stable branch HEAD, which is 2024.35. I did notice that the last 5 were already fixed, and I searched for existing issues, but missed T15824 sorry.

Fri, May 30, 00:37 · Phorge

Thu, May 29

aklapper requested review of D26036: Fix PHP 8.1 "preg_replace(null)" exception in PhabricatorEditorURIEngine.php.
Thu, May 29, 21:33
aklapper added a revision to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set: D26036: Fix PHP 8.1 "preg_replace(null)" exception in PhabricatorEditorURIEngine.php.
Thu, May 29, 21:33 · PHP 8 support, Deprecation Notice
aklapper added a comment to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set.

Looking at src/applications/repository/storage/PhabricatorRepository.php I see stuff like $has_shortname = ($this->getRepositorySlug() !== null); so it seems that a repository "slug" is what the UI calls a "short name". That's also seconded by code in DiffusionRepositoryEditEngine.

Thu, May 29, 21:22 · PHP 8 support, Deprecation Notice
aklapper added a comment to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set.

Copying from Q182:

PhabricatorEditorURIEngine.php:283, occurrences: 4
preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
arcanist(head=stable, ref.master=989690868513, ref.stable=05abd055019c), libphremoteuser(head=clarion, ref.master=944307decd9c, ref.clarion=d0da6c048bd5), phorge(head=stable, custom=4), translations(head=wmf/stable, ref.wmf/stable=76bb64361cec)
#0 preg_replace(string, string, NULL) called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:283]
#1 PhabricatorEditorURIEngine::escapeToken(NULL) called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:144]
#2 PhabricatorEditorURIEngine::newURITokensForRepository() called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:128]
#3 PhabricatorEditorURIEngine::getURITokensForRepository(string) called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:84]
#4 PhabricatorEditorURIEngine::getURITokensForPath(string) called at [<phorge>/src/applications/differential/view/DifferentialChangesetDetailView.php:371]
#5 DifferentialChangesetDetailView::getEditorURITemplate() called at [<phorge>/src/applications/differential/view/DifferentialChangesetDetailView.php:272]
#6 DifferentialChangesetDetailView::render() called at [<phorge>/src/applications/differential/view/DifferentialChangesetListView.php:240]
#7 DifferentialChangesetListView::render() called at [<phorge>/src/view/AphrontView.php:222]
#8 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115]
#9 phutil_escape_html(DifferentialChangesetListView) called at [<phorge>/src/infrastructure/markup/render.php:139]
#10 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:139]
#11 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:97]
#12 phutil_tag(string, array, array) called at [<phorge>/src/view/phui/PHUITwoColumnView.php:236]
#13 PHUITwoColumnView::buildFooter() called at [<phorge>/src/view/phui/PHUITwoColumnView.php:123]
#14 PHUITwoColumnView::getTagContent() called at [<phorge>/src/view/AphrontTagView.php:161]
#15 AphrontTagView::render() called at [<phorge>/src/view/AphrontView.php:222]
#16 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115]
#17 phutil_escape_html(PHUITwoColumnView) called at [<phorge>/src/infrastructure/markup/render.php:139]
#18 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:139]
#19 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:97]
#20 phutil_tag(string, array, array) called at [<phorge>/src/view/formation/PHUIFormationContentView.php:13]
#21 PHUIFormationContentView::render() called at [<phorge>/src/view/AphrontView.php:222]
#22 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115]
#23 phutil_escape_html(PHUIFormationContentView) called at [<phorge>/src/infrastructure/markup/render.php:139]
#24 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:97]
#25 phutil_tag(string, array, array) called at [<phorge>/src/view/formation/PHUIFormationView.php:58]
#26 PHUIFormationView::render() called at [<phorge>/src/view/AphrontView.php:222]
#27 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115]
#28 phutil_escape_html(PHUIFormationView) called at [<phorge>/src/infrastructure/markup/render.php:171]
#29 phutil_implode_html(string, array) called at [<phorge>/src/view/page/PhabricatorBarePageView.php:58]
#30 PhabricatorBarePageView::willRenderPage() called at [<phorge>/src/view/page/PhabricatorStandardPageView.php:217]
#31 PhabricatorStandardPageView::willRenderPage() called at [<phorge>/src/view/page/AphrontPageView.php:46]
#32 AphrontPageView::render() called at [<phorge>/src/view/page/PhabricatorStandardPageView.php:918]
#33 PhabricatorStandardPageView::produceAphrontResponse() called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:724]
#34 AphrontApplicationConfiguration::produceResponse(AphrontRequest, PhabricatorStandardPageView) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:299]
#35 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203]
#36 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]
Thu, May 29, 20:31 · PHP 8 support, Deprecation Notice
aklapper added a comment to D26034: Fix PHP 8.1 "strlen(null)" exception in Client ID handling of PhabricatorOAuthServerTokenController.

Thanks! Oh true I was forget the default fallback option... ah well I guess not a huge difference performance wise plus null feels cleaner to me :)

Thu, May 29, 17:44