I noted down that it did when I first hit this error, but not anymore. Now I have to go to a specific diff in which a new file has been added.

Happy to change those phutil_nonempty_string() into phutil_nonempty_scalar() because

1. The only place it matters is in DiffusionExternalController.php where this is called with:

$redirect = $repository->generateURI(
   array(
     'action' => 'browse',
     'branch' => $repository->getDefaultBranch(),
     'commit' => $id,
   ));

Maybe $id might be an int or float under some non-git VCS.

In D25323#9875, @valerio.bozzolan wrote:

Uhm. What about removing a file?

Can't find a test case in which the function returns null :-(

Has anyone experimented with using arcanist in a docker container? I see two people have published these on dockerhub:

• https://hub.docker.com/r/nasqueron/arcanist
• https://hub.docker.com/r/adlogix/arcanist

Wouldn't want to deny you your '0' comments!

Update empty string check to === '' as per review

Could we have a lint rule to catch forbidden newlines?

Interesting point about the array return.

coalesce - I like that. It's going to see some use!

Tested uploading a diff via the web interface, and it's fine with and without this patch.

Pesky newline removed :-)

I triggered the exceptions just by running 'arc diff'. Visiting a diff on the web interface was fine. Please see T15530 for the exception stack trace.

Nice - complete removal of that strlen as suggested.

In D25334#9617, @valerio.bozzolan wrote:

1. Probably we can avoid to create a "dummy" DifferentialTestCommitMessageField and just use something like DifferentialSubscribersCommitMessageField in the test case

Remove blank line

Try now - adding PHABRICATOR_TESTCONFIG_BUILD_STORAGE_FIXTURES has resolved the Database isolation exception in other test cases I've done.

Handle renderFieldValue in DifferentialRevisionIDCommitMessageField as well

Remove earlier changes to DiffusionBrowseTableView

Update as per peer review