I discovered the function phutil_nonempty_string().

I think we're done with this.

Maybe we can retry here (smaller):

Only users that have signed this agreement may be admitted to Blessed Committers.

This task is no longer valid as account approval is disabled.

Wow. Probably there was only one case. Let's stay ready to reopen, but probably we are OK.

It seems Rector.php has not an automatic rule for that.

I renamed the proposal from configString() to configStr() so that I do not break the 80 characters lint limitation ihih

In D25031#1902, @Ekubischta wrote:

This revision is nearly impossible to test

See my comments here D25030#1893

Error suppression with "@" is a poor solution to this issue

@Cigaryno I noticed this topic. I would say: be bold and just share it directly in Starmap marking it as stub (there is a button to do that)

I agree that an agreement could be useful but I don't think that the author should ever allow to re-license its work. I honestly do not want to allow my contributions to be re-licensed, since this usually means that the repository owner wants to re-license that work under a proprietary license when needed. I don't accept that. Normal volunteers do not accept that. This is probably not what we want.

I just want to mark this as resolved since Rector.php is quite nice and simple and we can surely use this tool to do nice things, even without adding it in our Composer but just locally, when we need it.

I'm pretty impressed by the power of Rector. I almost figured out how to use the 2% of it: Rector put my whole house in order, including Phorge and Arcanist that were on the bedside table.

This is partially related:

We should definitely prioritize this, as after November of this year we won’t support any stable/maintained versions of PHP

Expanding task to also include adding compatibility with PHP 8.2

I'm not assigned to this since I'm not really active. I was just curious. Feel free to give it a try and add more notes.

In T15047#3542, @avivey wrote:

I personally hate the $a = []; style, at least for empty arrays - I find it not-explicit enough.

In T15047#3538, @valerio.bozzolan wrote:

Maybe unrelated. Can we - right now - update the coding standard to avoid $a = array() (that is a tremendous old approach) to just adopt $a = []? Note that the short version was introduced in PHP 5.4, that already is the minimum version right now. I'm talking about this document:

https://we.phorge.it/book/contrib/article/php_coding_standards/

Maybe unrelated. Can we - right now - update the coding standard to avoid $a = array() (that is a tremendous old approach) to just adopt $a = []? Note that the short version was introduced in PHP 5.4, that already is the minimum version right now. I'm talking about this document: