Page MenuHomePhorge

Give embedded image files with transparency a checkered background
ClosedPublic

Authored by aklapper on Jun 14 2023, 18:44.
Tags
None
Referenced Files
F3828173: D25294.1746047255.diff
Tue, Apr 29, 21:07
F3828126: D25294.1746044409.diff
Tue, Apr 29, 20:20
F3827873: D25294.1746042655.diff
Tue, Apr 29, 19:50
F3814312: D25294.1746010287.diff
Tue, Apr 29, 10:51
F3806031: D25294.1745993428.diff
Tue, Apr 29, 06:10
F3801176: D25294.1745940653.diff
Mon, Apr 28, 15:30
F3766731: D25294.1745846524.diff
Sun, Apr 27, 13:22
F3738905: D25294.1745761128.diff
Sat, Apr 26, 13:38

Details

Summary

Have a consistent rendering experience between File page and file embedded in a task for PNG image files with an alpha channel:
Show a checkered background on the embedded image instead of a white background; show full contrast when hovering over the embedded image.

Closes T15473

Test Plan

See steps in T15473 - compare an image file embedded in a task before and after applying this patch.

  • test in Task description
  • test in Task comment
  • test in Task comment inside something weird like a table

Diff Detail

Repository
rP Phorge
Branch
EmbedImageFileCheckeredBg (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 557
Build 557: arc lint + arc unit

Event Timeline

valerio.bozzolan edited the test plan for this revision. (Show Details)

Nice catch!

lgtm

This revision is now accepted and ready to land.Jun 14 2023, 19:14