Differential D25128

Fix idx default empty string in ArcanistWorkflow
ClosedPublic
Actions

Authored by goddenrich on Apr 19 2023, 17:09.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies
T15259: arc patch broken on php 8.2 when certificate is uninstalled

Commits

rARC8c084061e180: Promote 2023.17 to stable
rARCca5f5cd1522c: Fix idx default empty string in ArcanistWorkflow

Summary

Another fix for PHP 8.1 deprecations.

Closes T15259
Ref T15190

Test Plan

Run arc patch with certificate uninstalled

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 258
Build 258: arc lint + arc unit

Event Timeline

goddenrich created this revision.Apr 19 2023, 17:09

Owners added a reviewer: O1: Blessed Committers.Apr 19 2023, 17:09

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptApr 19 2023, 17:09

Harbormaster completed remote builds in B258: Diff 503.Apr 19 2023, 17:09

goddenrich requested review of this revision.Apr 19 2023, 17:09

goddenrich added a task: T15259: arc patch broken on php 8.2 when certificate is uninstalled.Apr 19 2023, 17:09

goddenrich edited the summary of this revision. (Show Details)Apr 19 2023, 17:12

goddenrich added a task: T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.

This is totally legit. Thank you for this minimal patch that allows to never pass NULL to strlen.

sgtm

This revision is now accepted and ready to land.Apr 19 2023, 20:28

valerio.bozzolan retitled this revision from idx default empty string in ArcanistWorkflow to Fix idx default empty string in ArcanistWorkflow.Apr 19 2023, 20:31

valerio.bozzolan edited the summary of this revision. (Show Details)

valerio.bozzolan edited the test plan for this revision. (Show Details)

valerio.bozzolan mentioned this in T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).Apr 19 2023, 21:08

Closed by commit rARCca5f5cd1522c: Fix idx default empty string in ArcanistWorkflow. · Explain WhyApr 20 2023, 10:18

This revision was automatically updated to reflect the committed changes.

goddenrich added a commit: rARCca5f5cd1522c: Fix idx default empty string in ArcanistWorkflow.

valerio.bozzolan mentioned this in 2023 Week 2.Apr 20 2023, 16:07

avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54

avivey added a commit: rARC8c084061e180: Promote 2023.17 to stable.Apr 25 2023, 07:12

valerio.bozzolan mentioned this in Next Up (since Week 18).Apr 25 2023, 20:29

valerio.bozzolan mentioned this in D25383: Fix a PHP 8.1/8.2 deprecated use of strlen deprecated call with a NULL argument.Aug 11 2023, 09:51

Revision Contents
Changeset List

Path

Size

Packages

src/

workflow/

ArcanistWorkflow.php

4 lines

O1: Blessed Committers

Diff 503

src/workflow/ArcanistWorkflow.php

Loading...