Page MenuHomePhorge

Fix some PHP 8.1 issues in Diviner generator
ClosedPublic

Authored by valerio.bozzolan on Apr 14 2023, 14:52.
Tags
None
Referenced Files
F3850649: D25124.1746115673.diff
Wed, Apr 30, 16:07
F3830424: D25124.1746071365.diff
Wed, Apr 30, 03:49
F3763451: D25124.1745839277.diff
Sun, Apr 27, 11:21
F3686740: D25124.1745584702.diff
Thu, Apr 24, 12:38
F3675063: D25124.1745496952.diff
Wed, Apr 23, 12:15
F3503605: D25124.1744798280.diff
Tue, Apr 15, 10:11
F3399878: D25124.1744550140.diff
Sat, Apr 12, 13:15
F3397870: D25124.1744531315.diff
Sat, Apr 12, 08:01

Details

Summary

After this change I was able to generate again the Diviner
documentation from PHP 8.2 using the related command:

./bin/diviner generate

Closes T15255

Test Plan
  • run ./bin/diviner generate - great success
  • tested the advanced search in various ways - it still works

Diff Detail

Repository
rP Phorge
Branch
diviner-php81
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 251
Build 251: arc lint + arc unit

Event Timeline

Hi @speck :) How are you?

This is a present for you! and others of course

A small fix just for Diviner and PHP 8.1 - finally it seems it works

valerio.bozzolan added a subscriber: Ekubischta.

Hi @Ekubischta :) You may appreciate this small fix for PHP 8.1

Good news: with this, finally Diviner works again!

This revision is now accepted and ready to land.Apr 20 2023, 15:59