Page MenuHomePhorge

Fix some PHP 8.1 issues in Diviner generator
ClosedPublic

Authored by valerio.bozzolan on Apr 14 2023, 14:52.
Tags
None
Referenced Files
F3347606: D25124.1743721991.diff
Wed, Apr 2, 23:13
F3342114: D25124.1743661177.diff
Wed, Apr 2, 06:19
F3335610: D25124.1743564697.diff
Tue, Apr 1, 03:31
F3333543: D25124.1743536737.diff
Mon, Mar 31, 19:45
F3331879: D25124.1743514036.diff
Mon, Mar 31, 13:27
F3331876: D25124.1743514025.diff
Mon, Mar 31, 13:27
F3329704: D25124.1743479382.diff
Mon, Mar 31, 03:49
F3325006: D25124.1743407461.diff
Sun, Mar 30, 07:51

Details

Summary

After this change I was able to generate again the Diviner
documentation from PHP 8.2 using the related command:

./bin/diviner generate

Closes T15255

Test Plan
  • run ./bin/diviner generate - great success
  • tested the advanced search in various ways - it still works

Diff Detail

Repository
rP Phorge
Branch
diviner-php81
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 251
Build 251: arc lint + arc unit

Event Timeline

Hi @speck :) How are you?

This is a present for you! and others of course

A small fix just for Diviner and PHP 8.1 - finally it seems it works

valerio.bozzolan added a subscriber: Ekubischta.

Hi @Ekubischta :) You may appreciate this small fix for PHP 8.1

Good news: with this, finally Diviner works again!

This revision is now accepted and ready to land.Apr 20 2023, 15:59