Page MenuHomePhorge

Fix some PHP 8.1 issues in Diviner generator
ClosedPublic

Authored by valerio.bozzolan on Apr 14 2023, 14:52.
Tags
None
Referenced Files
F2950193: D25124.1738731265.diff
Tue, Feb 4, 04:54
F2946719: D25124.1738411858.diff
Fri, Jan 31, 12:10
F2943281: D25124.1738175180.diff
Tue, Jan 28, 18:26
F2941206: D25124.1738101699.diff
Mon, Jan 27, 22:01
F2937131: D25124.1737947833.diff
Sun, Jan 26, 03:17
F2931813: D25124.1737726789.diff
Thu, Jan 23, 13:53
F2905306: D25124.1737342509.diff
Sun, Jan 19, 03:08
F2868434: D25124.1736665733.diff
Sat, Jan 11, 07:08

Details

Summary

After this change I was able to generate again the Diviner
documentation from PHP 8.2 using the related command:

./bin/diviner generate

Closes T15255

Test Plan
  • run ./bin/diviner generate - great success
  • tested the advanced search in various ways - it still works

Diff Detail

Repository
rP Phorge
Branch
diviner-php81
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 251
Build 251: arc lint + arc unit

Event Timeline

Hi @speck :) How are you?

This is a present for you! and others of course

A small fix just for Diviner and PHP 8.1 - finally it seems it works

valerio.bozzolan added a subscriber: Ekubischta.

Hi @Ekubischta :) You may appreciate this small fix for PHP 8.1

Good news: with this, finally Diviner works again!

This revision is now accepted and ready to land.Apr 20 2023, 15:59