Page MenuHomePhorge
Differential D25124

Fix some PHP 8.1 issues in Diviner generator
ClosedPublic
Actions

Authored by valerio.bozzolan on Apr 14 2023, 14:52.
Tags
None
Referenced Files
F2167337: D25124.diff
Sat, Apr 27, 19:38
Unknown Object (File)
Mon, Apr 8, 06:42
Unknown Object (File)
Fri, Apr 5, 13:28
Unknown Object (File)
Wed, Apr 3, 17:36
Unknown Object (File)
Mon, Apr 1, 01:14
Unknown Object (File)
Mon, Apr 1, 01:14
Unknown Object (File)
Mon, Apr 1, 01:14
Unknown Object (File)
Sun, Mar 31, 03:09
View All 90 Files
Subscribers
Cigaryno
Ekubischta
Matthew
speck
tobiaswiese

Details

Reviewers
Matthew
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15255: Fix Diviner generation in PHP 8
T15226: Fix Diviner creation in PHP 8.1: strlen(): passing null to parameter #1 is deprecated - DivinerGenerateWorkflow.php:197
Commits
rP1ba5c8c26095: Fix some PHP 8.1 issues in Diviner generator
Summary

After this change I was able to generate again the Diviner
documentation from PHP 8.2 using the related command:

./bin/diviner generate

Closes T15255

Test Plan
  • run ./bin/diviner generate - great success
  • tested the advanced search in various ways - it still works

Diff Detail

Repository
rP Phorge
Branch
diviner-php81
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 251
Build 251: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Apr 14 2023, 14:52
Owners added a reviewer: O1: Blessed Committers.Apr 14 2023, 14:52
Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptApr 14 2023, 14:52
valerio.bozzolan requested review of this revision.Apr 14 2023, 14:52
Harbormaster completed remote builds in B251: Diff 492.Apr 14 2023, 14:52
valerio.bozzolan edited the summary of this revision. (Show Details)Apr 14 2023, 15:19
valerio.bozzolan added a task: T15255: Fix Diviner generation in PHP 8.
valerio.bozzolan added a comment.Apr 14 2023, 18:46

Hi @speck :) How are you?

This is a present for you! and others of course

A small fix just for Diviner and PHP 8.1 - finally it seems it works

valerio.bozzolan edited the test plan for this revision. (Show Details)Apr 14 2023, 20:19
valerio.bozzolan added a subscriber: Ekubischta.

Hi @Ekubischta :) You may appreciate this small fix for PHP 8.1

Good news: with this, finally Diviner works again!

valerio.bozzolan mentioned this in Z1: Phorge.Apr 18 2023, 15:13
Matthew accepted this revision.Apr 20 2023, 15:59
This revision is now accepted and ready to land.Apr 20 2023, 15:59
Closed by commit rP1ba5c8c26095: Fix some PHP 8.1 issues in Diviner generator. · Explain WhyApr 20 2023, 16:00
This revision was automatically updated to reflect the committed changes.
valerio.bozzolan added a commit: rP1ba5c8c26095: Fix some PHP 8.1 issues in Diviner generator.
valerio.bozzolan mentioned this in 2023 Week 2.Apr 20 2023, 16:07
avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54
valerio.bozzolan mentioned this in Next Up (since Week 18).Apr 25 2023, 13:52

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
applications/
diviner/
query/
4 lines1%
Loading...
O1: Blessed Committers
storage/
2 lines2%
Loading...
O1: Blessed Committers
workflow/
2 lines0%
Loading...
O1: Blessed Committers

Diff 492

View Options

src/applications/diviner/query/DivinerBookQuery.php

Loading...
View Options

src/applications/diviner/storage/DivinerLiveSymbol.php

Loading...
View Options

src/applications/diviner/workflow/DivinerGenerateWorkflow.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0