Differential D25100

PHP 8.2: fix deprecated creation of dynamic properties
ClosedPublic
Actions

Authored by valerio.bozzolan on Mar 26 2023, 16:49.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15201: PHP 8.2: creation of dynamic property is deprecated

Commits

rPd98c47041f13: PHP 8.2: fix deprecated creation of dynamic properties

Summary

This change fixes a typo that, in PHP 8.2, causes this exception:

Creation of dynamic property PhabricatorAuthPasswordException::$confirmError is deprecated

Closes T15201

Test Plan

I checked that "error" was spelled with two "r"

Diff Detail

Repository

rP Phorge

Branch

asd

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 192
Build 192: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Mar 26 2023, 16:49

Owners added a reviewer: O1: Blessed Committers.Mar 26 2023, 16:49

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMar 26 2023, 16:49

valerio.bozzolan requested review of this revision.Mar 26 2023, 16:49

Harbormaster completed remote builds in B191: Diff 406.Mar 26 2023, 16:49

valerio.bozzolan removed a task: T15200: PHP 8.2: Use of "parent" in callables is deprecated.Mar 26 2023, 16:54

valerio.bozzolan mentioned this in Z1: Phorge.Mar 26 2023, 20:26

valerio.bozzolan edited the summary of this revision. (Show Details)

avivey accepted this revision.Mar 26 2023, 20:28

This revision is now accepted and ready to land.Mar 26 2023, 20:28

checkout master and cherry-pick from D25100

Harbormaster completed remote builds in B192: Diff 408.Mar 27 2023, 05:09

Closed by commit rPd98c47041f13: PHP 8.2: fix deprecated creation of dynamic properties. · Explain WhyMar 27 2023, 05:10

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rPd98c47041f13: PHP 8.2: fix deprecated creation of dynamic properties.

valerio.bozzolan mentioned this in 2023 Week 2.Mar 27 2023, 05:14

valerio.bozzolan mentioned this in T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).Mar 27 2023, 05:37

valerio.bozzolan mentioned this in 2023-03-27.Mar 28 2023, 05:55

avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

auth/

password/

PhabricatorAuthPasswordException.php

2 lines

71%

O1: Blessed Committers

Diff 408

View Options

src/applications/auth/password/PhabricatorAuthPasswordException.php

PHP 8.2: fix deprecated creation of dynamic propertiesClosedPublicActions