Page MenuHomePhorge

Drag & Drop: set a link as external
ClosedPublic

Authored by valerio.bozzolan on Mar 17 2023, 12:20.
Tags
None
Referenced Files
F2172835: D25077.id350.diff
Wed, May 1, 09:39
F2172834: D25077.id348.diff
Wed, May 1, 09:38
Unknown Object (File)
Mon, Apr 29, 19:35
Unknown Object (File)
Mon, Apr 29, 19:35
Unknown Object (File)
Mon, Apr 29, 08:15
Unknown Object (File)
Sun, Apr 28, 13:17
Unknown Object (File)
Thu, Apr 25, 10:49
Unknown Object (File)
Thu, Apr 25, 10:49

Details

Summary

Rest assured: external links remain evil, by default.

Don't adopt them randomly by induction.

Whether you believe it or not, this specific external
link merited some deep thoughts on Phorge:

So, whenever you use a mouse, a finger, or whenever we have
a confirmation dialog or not to prevent onblur disasters,
this change is probably consistent with common expectations.

Having said, external links remain evil - by default.

Closes T15172

Test Plan
  • Drag & Drop a File on a Remarkup text
  • click on the link inside the popup
  • it opens in a new tab (without risk of form loss)

Diff Detail

Repository
rP Phorge
Branch
T15172-drag-and-drop-popup-target-blank
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 139
Build 139: arc lint + arc unit

Event Timeline

fix lint error "Line Too Long"

This revision is now accepted and ready to land.Mar 17 2023, 12:54