Page MenuHomePhorge

Drag & Drop: set a link as external
ClosedPublic

Authored by valerio.bozzolan on Mar 17 2023, 12:20.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 10, 23:22
Unknown Object (File)
Wed, Apr 10, 17:49
Unknown Object (File)
Sun, Apr 7, 06:14
Unknown Object (File)
Thu, Apr 4, 08:40
Unknown Object (File)
Wed, Apr 3, 04:56
Unknown Object (File)
Mon, Apr 1, 00:56
Unknown Object (File)
Mon, Apr 1, 00:56
Unknown Object (File)
Mon, Apr 1, 00:56

Details

Summary

Rest assured: external links remain evil, by default.

Don't adopt them randomly by induction.

Whether you believe it or not, this specific external
link merited some deep thoughts on Phorge:

So, whenever you use a mouse, a finger, or whenever we have
a confirmation dialog or not to prevent onblur disasters,
this change is probably consistent with common expectations.

Having said, external links remain evil - by default.

Closes T15172

Test Plan
  • Drag & Drop a File on a Remarkup text
  • click on the link inside the popup
  • it opens in a new tab (without risk of form loss)

Diff Detail

Repository
rP Phorge
Branch
T15172-drag-and-drop-popup-target-blank
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 139
Build 139: arc lint + arc unit

Event Timeline

fix lint error "Line Too Long"

This revision is now accepted and ready to land.Mar 17 2023, 12:54