Page MenuHomePhorge

Drag & Drop: set a link as external
ClosedPublic

Authored by valerio.bozzolan on Mar 17 2023, 12:20.
Tags
None
Referenced Files
F2162421: D25077.id350.diff
Thu, Apr 25, 10:49
F2162420: D25077.id349.diff
Thu, Apr 25, 10:49
F2162419: D25077.id348.diff
Thu, Apr 25, 10:49
F2157628: D25077.id.diff
Wed, Apr 24, 22:23
F2157539: D25077.diff
Wed, Apr 24, 21:17
Unknown Object (File)
Wed, Apr 24, 06:36
Unknown Object (File)
Wed, Apr 10, 23:22
Unknown Object (File)
Wed, Apr 10, 17:49

Details

Summary

Rest assured: external links remain evil, by default.

Don't adopt them randomly by induction.

Whether you believe it or not, this specific external
link merited some deep thoughts on Phorge:

So, whenever you use a mouse, a finger, or whenever we have
a confirmation dialog or not to prevent onblur disasters,
this change is probably consistent with common expectations.

Having said, external links remain evil - by default.

Closes T15172

Test Plan
  • Drag & Drop a File on a Remarkup text
  • click on the link inside the popup
  • it opens in a new tab (without risk of form loss)

Diff Detail

Repository
rP Phorge
Branch
T15172-drag-and-drop-popup-target-blank
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/core/FileUpload.js:127TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 138
Build 138: arc lint + arc unit

Event Timeline

fix lint error "Line Too Long"

This revision is now accepted and ready to land.Mar 17 2023, 12:54