Page MenuHomePhorge

Drag & Drop: set a link as external
ClosedPublic

Authored by valerio.bozzolan on Mar 17 2023, 12:20.
Tags
None
Referenced Files
F2998653: D25077.1740414776.diff
Sun, Feb 23, 16:32
F2991510: D25077.1740184484.diff
Fri, Feb 21, 00:34
F2991509: D25077.1740184482.diff
Fri, Feb 21, 00:34
F2991507: D25077.1740184481.diff
Fri, Feb 21, 00:34
F2981687: D25077.1739922724.diff
Mon, Feb 17, 23:52
F2980273: D25077.1739888464.diff
Mon, Feb 17, 14:21
F2945081: D25077.1738288097.diff
Jan 30 2025, 01:48
F2943487: D25077.1738195796.diff
Jan 29 2025, 00:09

Details

Summary

Rest assured: external links remain evil, by default.

Don't adopt them randomly by induction.

Whether you believe it or not, this specific external
link merited some deep thoughts on Phorge:

So, whenever you use a mouse, a finger, or whenever we have
a confirmation dialog or not to prevent onblur disasters,
this change is probably consistent with common expectations.

Having said, external links remain evil - by default.

Closes T15172

Test Plan
  • Drag & Drop a File on a Remarkup text
  • click on the link inside the popup
  • it opens in a new tab (without risk of form loss)

Diff Detail

Repository
rP Phorge
Branch
T15172-drag-and-drop-popup-target-blank
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 139
Build 139: arc lint + arc unit

Event Timeline

fix lint error "Line Too Long"

This revision is now accepted and ready to land.Mar 17 2023, 12:54