Page MenuHomePhorge

Drag & Drop: set a link as external
ClosedPublic

Authored by valerio.bozzolan on Mar 17 2023, 12:20.
Tags
None
Referenced Files
F3358355: D25077.1743922081.diff
Sat, Apr 5, 06:48
F3355214: D25077.1743871748.diff
Fri, Apr 4, 16:49
F3349527: D25077.1743756383.diff
Thu, Apr 3, 08:46
F3349526: D25077.1743756382.diff
Thu, Apr 3, 08:46
F3347388: D25077.1743718613.diff
Wed, Apr 2, 22:16
F3334967: D25077.1743556031.diff
Tue, Apr 1, 01:07
F3331902: D25077.1743514829.diff
Mon, Mar 31, 13:40
F3330417: D25077.1743488333.diff
Mon, Mar 31, 06:18

Details

Summary

Rest assured: external links remain evil, by default.

Don't adopt them randomly by induction.

Whether you believe it or not, this specific external
link merited some deep thoughts on Phorge:

So, whenever you use a mouse, a finger, or whenever we have
a confirmation dialog or not to prevent onblur disasters,
this change is probably consistent with common expectations.

Having said, external links remain evil - by default.

Closes T15172

Test Plan
  • Drag & Drop a File on a Remarkup text
  • click on the link inside the popup
  • it opens in a new tab (without risk of form loss)

Diff Detail

Repository
rP Phorge
Branch
T15172-drag-and-drop-popup-target-blank
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 139
Build 139: arc lint + arc unit

Event Timeline

fix lint error "Line Too Long"

This revision is now accepted and ready to land.Mar 17 2023, 12:54