Page MenuHomePhorge

Drag & Drop: set a link as external
ClosedPublic

Authored by valerio.bozzolan on Mar 17 2023, 12:20.
Tags
None
Referenced Files
F3785196: D25077.1745910797.diff
Mon, Apr 28, 07:13
F3576072: D25077.1745024536.diff
Fri, Apr 18, 01:02
F3377167: D25077.1744336263.diff
Thu, Apr 10, 01:51
F3375736: D25077.1744312449.diff
Wed, Apr 9, 19:14
F3372055: D25077.1744247885.diff
Wed, Apr 9, 01:18
F3372051: D25077.1744247867.diff
Wed, Apr 9, 01:17
F3369479: D25077.1744215018.diff
Tue, Apr 8, 16:10
F3369349: D25077.1744214407.diff
Tue, Apr 8, 16:00

Details

Summary

Rest assured: external links remain evil, by default.

Don't adopt them randomly by induction.

Whether you believe it or not, this specific external
link merited some deep thoughts on Phorge:

So, whenever you use a mouse, a finger, or whenever we have
a confirmation dialog or not to prevent onblur disasters,
this change is probably consistent with common expectations.

Having said, external links remain evil - by default.

Closes T15172

Test Plan
  • Drag & Drop a File on a Remarkup text
  • click on the link inside the popup
  • it opens in a new tab (without risk of form loss)

Diff Detail

Repository
rP Phorge
Branch
T15172-drag-and-drop-popup-target-blank
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 139
Build 139: arc lint + arc unit

Event Timeline

fix lint error "Line Too Long"

This revision is now accepted and ready to land.Mar 17 2023, 12:54