Page MenuHomePhorge

Drag & Drop: set a link as external
ClosedPublic

Authored by valerio.bozzolan on Mar 17 2023, 12:20.
Tags
None
Referenced Files
F2945081: D25077.1738288097.diff
Thu, Jan 30, 01:48
F2943487: D25077.1738195796.diff
Wed, Jan 29, 00:09
F2942773: D25077.1738134861.diff
Tue, Jan 28, 07:14
F2931825: D25077.1737727635.diff
Thu, Jan 23, 14:07
F2920545: D25077.1737546469.diff
Tue, Jan 21, 11:47
F2920486: D25077.1737546449.diff
Tue, Jan 21, 11:47
F2914868: D25077.1737444537.diff
Mon, Jan 20, 07:28
F2914838: D25077.1737444526.diff
Mon, Jan 20, 07:28

Details

Summary

Rest assured: external links remain evil, by default.

Don't adopt them randomly by induction.

Whether you believe it or not, this specific external
link merited some deep thoughts on Phorge:

So, whenever you use a mouse, a finger, or whenever we have
a confirmation dialog or not to prevent onblur disasters,
this change is probably consistent with common expectations.

Having said, external links remain evil - by default.

Closes T15172

Test Plan
  • Drag & Drop a File on a Remarkup text
  • click on the link inside the popup
  • it opens in a new tab (without risk of form loss)

Diff Detail

Repository
rP Phorge
Branch
T15172-drag-and-drop-popup-target-blank
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/core/FileUpload.js:127TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 138
Build 138: arc lint + arc unit

Event Timeline

fix lint error "Line Too Long"

This revision is now accepted and ready to land.Mar 17 2023, 12:54