The CTRL+click now opens the links in a new tab, like any other
normal link opened with CTRL+click.
Note that the middle-click was already working.
Closes T15157
Details
Details
- Reviewers
avivey - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15157: "Create Task" and "Edit Task" should open links in a new tab when CTRL-click
- Commits
- rPc6f56b8221ba: Workboard: fix CTRL+click on "Create Task" and "Edit Task"
- visit a Workboard
- column > menu > mouse on "Create Task"
- CTRL+click: open in new tab (→ now works)
- normal click: open the pop-up (→ still works)
- middle-click: open in new tab (→ still works)
- column > single Task > mouse on "Edit"
- CTRL+click: open in new tab (→ now works)
- normal click: open the pop-up (→ still works)
- middle-click: open in new tab (→ still works)
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- T15157-workboard-fix-create-task-ctrl-click
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 127 Build 127: arc lint + arc unit
Event Timeline
Comment Actions
I tried to keep the diff as much small as possible. That is why I just added a small piece of code with a return; instead of a bigger refactoring.
Comment Actions
So the goal is:
- stop other listeners: that's why I've adopted stop()
- don't prevent anything: that's why I've not called prevent()
- don't open the pop-up: that's why I've set that return;
Comment Actions
This patch also tries improves the user experience of this diff:
D25068: Workboard: improve the Create Task link to mention the Project slug
Anyway we can approve and land this or that in any order.
Comment Actions
The funny part is: every time I read this comment I'm even more confused. But hey, it works.