Remove orphan CSS selectors in calendar/phui-calendar.css
AcceptedPublic
Actions

Authored by aklapper on Thu, May 8, 13:49.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Summary

phui-calendar-bg-blue
phui-calendar-bg-green
phui-calendar-bg-grey
phui-calendar-bg-indigo
phui-calendar-bg-orange
phui-calendar-bg-red
phui-calendar-bg-sky
phui-calendar-bg-viewer-invited
phui-calendar-bg-violet
phui-calendar-bg-yellow
phui-calendar-blue
phui-calendar-green
phui-calendar-grey
phui-calendar-indigo
phui-calendar-orange
phui-calendar-red
phui-calendar-sky
phui-calendar-violet
phui-calendar-yellow
phui-calendar-event-empty
phui-calendar-list-dot
phui-calendar-viewer-invited
- Added in https://we.phorge.it/rP396e8ba82c221c085d17f1574551fbff42459452, usage removed in https://we.phorge.it/rP4016107411c12d8658a2cfeefeef19b7c12fa6cb ($class = 'phui-calendar-list-item phui-calendar-'.$color;) resp. https://we.phorge.it/rPb6c3d184d200e6bc43ba8f15a069c3a8620779cc from src/view/phui/calendar/PHUICalendarListView.php

Test Plan

Grep the code for each CSS selector (grep --exclude="*.css" -R 'some-search-string' .), also do partial searches, get no results.
Optionally, play with calendar list view.

Create events in which you are:

Busy
Available
Away
Invited
Invited and Confirmed

No visible color regressions.

Diff Detail

Repository

rP Phorge

Branch

cssDead7 (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1954
Build 1954: arc lint + arc unit

Event Timeline

aklapper created this revision.Thu, May 8, 13:49

Owners added a reviewer: O1: Blessed Committers.Thu, May 8, 13:49

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptThu, May 8, 13:49

aklapper requested review of this revision.Thu, May 8, 13:49

Harbormaster completed remote builds in B1954: Diff 3008.Thu, May 8, 13:49

aklapper edited the summary of this revision. (Show Details)Thu, May 8, 13:50

valerio.bozzolan awarded a token.Tue, May 20, 12:38

Should we also add some PHPDoc @deprecate (or whatever its name) to most CalendarColors?

In D26000#27460, @valerio.bozzolan wrote:

Should we also add some PHPDoc @deprecate (or whatever its name) to most CalendarColors?

If you had asked me ten years ago, maybe... but now it's all too late!!1
https://we.phorge.it/rPdbd7e3c56de4e2460b23debcd1ce8c8c1114b2c8

Is getDisplayIconColor() related to these? (spoiler: probably it's not)

webroot/rsrc/css/phui/calendar/phui-calendar.css
26–28	Maybe `.phui-calendar-viewer-invited` can be removed also from phui-calendar-list.css and phui-calendar-month.css

In D26000#27480, @valerio.bozzolan wrote:

Is getDisplayIconColor() related to these? (spoiler: probably it's not)

In my understanding that's unrelated because the results of all calls to getDisplayIconColor() in src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php don't call functions which would concatenate some .phui-calendar- prefix? Hmm.