task-edit.css
ClosedPublic
Actions

Authored by aklapper on Fri, May 2, 13:32.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP5f7250fea617: Remove unused feed/feed.css and maniphest/task-edit.css

Summary

webroot/rsrc/css/application/feed/feed.css: .phabricator-public-feed-frame .phui-feed-story-foot, webroot/rsrc/css/application/feed/feed.css: .phabricator-public-feed-frame .phui-feed-story, webroot/rsrc/css/application/feed/feed.css: .phabricator-public-feed-frame .phui-feed-wrap
- Added in https://we.phorge.it/rP6e86a04ab106f4d3c9e32f2b3890a0fa137e43a2, usage removed in https://we.phorge.it/rP6a996d76fd1a1a144177b1fb9e10c816f0e8e98e
webroot/rsrc/css/application/feed/feed.css: .phabricator-feed-newer-link, webroot/rsrc/css/application/feed/feed.css: .phabricator-feed-older-link
- Added in https://we.phorge.it/rP29acc848c14a1680a54a3a744610f8c83e27bb12, usage removed in https://we.phorge.it/rP310cf00fc3cce6a023ad160a29def26845d82e26
webroot/rsrc/css/application/maniphest/task-edit.css: .maniphest-auxiliary-header
- Added in https://we.phorge.it/rP3c1a0b76fac86c9f40222c5bb79fcddb996d1c9e, usage removed in https://we.phorge.it/rP5251e2f14d8e54157cc33094e7c29d8a6c2f9259

Note: This is always a bit dangerous because of some concatenation like 'class' => 'toggle'.$more in the codebase.

Test Plan

Grep the code for the parent CSS selector, also doing a partial search. Example:

$ grep --exclude="*.css" -R 'feed-newer-link' .
$ grep --exclude="*.css" -R 'feed-older-link' .
$ grep --exclude="*.css" -R 'public-feed-frame ' .
$ grep --exclude="*.css" -R 'auxiliary-header' .

No results.

Diff Detail

Repository

rP Phorge

Branch

cssDead1 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1951
Build 1951: arc lint + arc unit

Event Timeline

aklapper created this revision.Fri, May 2, 13:32

Owners added a reviewer: O1: Blessed Committers.Fri, May 2, 13:32

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFri, May 2, 13:32

aklapper requested review of this revision.Fri, May 2, 13:32

Harbormaster completed remote builds in B1913: Diff 2958.Fri, May 2, 15:20

Thaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaanks

This revision is now accepted and ready to land.Wed, May 7, 16:21

aklapper retitled this revision from Remove some unused CSS files to Remove unused CSS files feed/feed.css and maniphest/task-edit.css.Wed, May 7, 23:10

git rebase master

Harbormaster completed remote builds in B1951: Diff 3004.Thu, May 8, 11:24

aklapper retitled this revision from Remove unused CSS files feed/feed.css and maniphest/task-edit.css to Remove unused feed/feed.css and maniphest/task-edit.css.Thu, May 8, 12:21

Closed by commit rP5f7250fea617: Remove unused feed/feed.css and maniphest/task-edit.css. · Explain WhyThu, May 8, 12:21

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP5f7250fea617: Remove unused feed/feed.css and maniphest/task-edit.css.

aklapper mentioned this in Next Up.Thu, May 8, 12:22