Page MenuHomePhorge
Differential D25997

Remove orphan CSS selectors for differential-haunt-mode
ClosedPublic
Actions

Authored by aklapper on Wed, May 7, 23:25.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rP2ce25747851f: Remove orphan CSS selectors for differential-haunt-mode
Summary

Added in rP29d8fc04e50b83fc7cf09f428ef905aa5e54e838.
Usage removed in rPb5722a99635adb513036b9741fccdfc61b5e4472.

Test Plan

Grep the code for "haunt". Get no results.

Diff Detail

Repository
rP Phorge
Branch
cssDead4 (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1950
Build 1950: arc lint + arc unit

Event Timeline

aklapper created this revision.Wed, May 7, 23:25
Owners added a reviewer: O1: Blessed Committers.Wed, May 7, 23:25
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptWed, May 7, 23:25
aklapper requested review of this revision.Wed, May 7, 23:25
Harbormaster completed remote builds in B1950: Diff 3003.Wed, May 7, 23:25
aklapper mentioned this in D26010: Remove orphan CSS selectors in core/z-index.css.Sat, May 10, 11:25
aklapper mentioned this in rP854dc7f3f503: Remove orphan CSS selectors in core/z-index.css.Wed, May 14, 22:34
valerio.bozzolan accepted this revision.Fri, May 16, 20:56
valerio.bozzolan added inline comments.
webroot/rsrc/css/core/z-index.css
100–104

The differential-haunt-mode has matches also here:

./webroot/rsrc/css/application/differential/revision-comment.css:
This revision is now accepted and ready to land.Fri, May 16, 20:56
aklapper added inline comments.Sat, May 17, 01:19
webroot/rsrc/css/core/z-index.css
100–104

That's why we remove that file in this patch :P

aklapper updated this revision to Diff 3055.Sat, May 17, 01:22

git rebase master

Harbormaster completed remote builds in B1983: Diff 3055.Sat, May 17, 01:22
valerio.bozzolan accepted this revision.Sat, May 17, 07:36

looool double-slam-accept

webroot/rsrc/css/core/z-index.css
100–104

looool

Closed by commit rP2ce25747851f: Remove orphan CSS selectors for differential-haunt-mode. · Explain WhySat, May 17, 09:20
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rP2ce25747851f: Remove orphan CSS selectors for differential-haunt-mode.
aklapper mentioned this in Next Up.Tue, May 20, 06:35

Revision Contents
Changeset List

PathSizePackages
resources/
celerity/
O1: Blessed Committers
1 lineO1: Blessed Committers
webroot/
rsrc/
css/
application/
differential/
O1: Blessed Committers
core/
5 linesO1: Blessed Committers

Diff 3003

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

webroot/rsrc/css/application/differential/revision-comment.css

Loading...
View Options

webroot/rsrc/css/core/z-index.css

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0