Paths

Table of Contentst

Differential D25995

Remove orphan CSS selectors in PHUIFormView
ClosedPublic
Actions

Authored by aklapper on Wed, May 7, 17:00.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP5e64a0a81903: Remove orphan CSS selectors in PHUIFormView

Summary

aphront-form-drag-and-drop-upload
- Usage removed in https://we.phorge.it/rPdd76143399d8b77a14baca44f99051aa6298e487
aphront-form-important
- Usage removed in https://we.phorge.it/rPc585f97e90d2ff1e2713f613c2e56149ae37aaf6
aphront-form-control-togglebuttons
- Usage removed in https://we.phorge.it/rPa1403183dfcfb6886cc75153044745d9cc70687b
aphront-form-control-image
- Usage removed in https://we.phorge.it/rPa1403183dfcfb6886cc75153044745d9cc70687b
aphront-form-drag-and-drop-file-list
- Usage removed in https://we.phorge.it/rPdd76143399d8b77a14baca44f99051aa6298e487
aphront-form-crop
- Usage removed in https://we.phorge.it/rPa1403183dfcfb6886cc75153044745d9cc70687b

Extra children checks:

crop-box
- Usage removed in https://we.phorge.it/rPa1403183dfcfb6886cc75153044745d9cc70687b
crop-image
- Usage removed in https://we.phorge.it/rPa1403183dfcfb6886cc75153044745d9cc70687b and https://we.phorge.it/rP524906a4396a33974974977065bf0ae05ca7dc5c
default-image
- Usage removed in https://we.phorge.it/rPa1403183dfcfb6886cc75153044745d9cc70687b

Test Plan

Grep the code for each CSS selector (grep --exclude="*.css" -R 'some-search-string' .), also do partial searches, get no results.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1948
Build 1948: arc lint + arc unit

Event Timeline

aklapper created this revision.Wed, May 7, 17:00

Owners added a reviewer: O1: Blessed Committers.Wed, May 7, 17:00

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptWed, May 7, 17:00

aklapper requested review of this revision.Wed, May 7, 17:00

Harbormaster completed remote builds in B1948: Diff 3001.Wed, May 7, 17:00

Very good job as usual 👍

I update the description just to be in order with the shown changes, and splitting the important checks (e.g. parent selectors) from the extra ones (e.g. child selectors).

webroot/rsrc/css/phui/phui-form-view.css
101–104	✅
184–194	✅
204–207	✅
247–255	✅
279–282	✅
300–310	✅

This revision is now accepted and ready to land.Thu, May 22, 12:47

valerio.bozzolan edited the summary of this revision. (Show Details)Thu, May 22, 12:47

git rebase master

Harbormaster completed remote builds in B2010: Diff 3092.Thu, May 22, 16:35

Closed by commit rP5e64a0a81903: Remove orphan CSS selectors in PHUIFormView. · Explain WhyFri, May 23, 00:08

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP5e64a0a81903: Remove orphan CSS selectors in PHUIFormView.

Revision Contents
Changeset List

Path

Size

Packages

resources/

celerity/

O1: Blessed Committers

webroot/

rsrc/

css/

phui/

phui-form-view.css

43 lines

O1: Blessed Committers

Diff 3001

resources/celerity/map.php

Loading...

webroot/rsrc/css/phui/phui-form-view.css

Loading...