Page MenuHomePhorge
Differential D25928

Remove some pre-2013 vendor-prefixed -ms- CSS properties
ClosedPublic
Actions

Authored by aklapper on Thu, Mar 27, 18:11.
Tags
None
Referenced Files
F3346795: D25928.1743707030.diff
Wed, Apr 2, 19:03
F3346793: D25928.1743707023.diff
Wed, Apr 2, 19:03
F3346190: D25928.1743697306.diff
Wed, Apr 2, 16:21
F3340806: D25928.1743643188.diff
Wed, Apr 2, 01:19
F3340550: D25928.1743638217.diff
Tue, Apr 1, 23:56
F3336592: D25928.1743576913.diff
Tue, Apr 1, 06:55
F3336120: D25928.1743569957.diff
Tue, Apr 1, 04:59
F3334158: D25928.1743545640.diff
Mon, Mar 31, 22:14
View All 21 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rP112174b900cb: Remove some pre-2013 vendor-prefixed -ms- CSS properties
Summary

Per https://caniuse.com/ and MDN,

  • -ms-transform superseded by unprefixed transform supported since IE 10 released 09/2012
  • @-ms-keyframes superseded by unprefixed @keyframes supported since IE 10 released 09/2012
  • -ms-transition superseded by unprefixed transition supported since IE 10 released 09/2012
Test Plan

None. Probably installing old browser versions if you don't trust documentation.

Diff Detail

Repository
rP Phorge
Branch
cssMSprefix (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1811
Build 1811: arc lint + arc unit

Event Timeline

aklapper created this revision.Thu, Mar 27, 18:11
Owners added a reviewer: O1: Blessed Committers.Thu, Mar 27, 18:11
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptThu, Mar 27, 18:11

Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:

./bin/celerity map

⚙️ Thanks! Bip bop I'm a bot - helping for T15209

aklapper requested review of this revision.Thu, Mar 27, 18:11
Harbormaster completed remote builds in B1811: Diff 2789.Thu, Mar 27, 18:11
valerio.bozzolan accepted this revision.Thu, Mar 27, 18:52

chadyes

This revision is now accepted and ready to land.Thu, Mar 27, 18:52
aklapper updated this revision to Diff 2792.Fri, Mar 28, 05:55

git rebase master

Harbormaster completed remote builds in B1813: Diff 2792.Fri, Mar 28, 05:55
aklapper edited the summary of this revision. (Show Details)Fri, Mar 28, 05:57
Closed by commit rP112174b900cb: Remove some pre-2013 vendor-prefixed -ms- CSS properties. · Explain WhyFri, Mar 28, 05:57
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rP112174b900cb: Remove some pre-2013 vendor-prefixed -ms- CSS properties.
aklapper mentioned this in Next Up.Fri, Mar 28, 06:07

Revision Contents
Changeset List

Diff 2789

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio.css

Loading...
View Options

webroot/rsrc/css/font/phui-font-icon-base.css

Loading...
View Options

webroot/rsrc/css/phui/phui-timeline-view.css

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0