Page MenuHomePhorge
Differential D25924

Remove invalid CSS border-shadow property for input.jx-tokenizer-input
ClosedPublic
Actions

Authored by aklapper on Tue, Mar 25, 09:56.
Tags
None
Referenced Files
F3454512: D25924.1744726782.diff
Mon, Apr 14, 14:19
F3388618: D25924.1744447520.diff
Fri, Apr 11, 08:45
F3388616: D25924.1744447513.diff
Fri, Apr 11, 08:45
F3388614: D25924.1744447509.diff
Fri, Apr 11, 08:45
F3388612: D25924.1744447506.diff
Fri, Apr 11, 08:45
F3387399: D25924.1744436496.diff
Fri, Apr 11, 05:41
F3364793: D25924.1744161030.diff
Tue, Apr 8, 01:10
F3363032: D25924.1744107776.diff
Mon, Apr 7, 10:22
View All 33 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rPa8c2bce6fe98: Remove invalid CSS border-shadow property for input.jx-tokenizer-input
Summary

The W3C CSS validator throws Property border-shadow doesn't exist : none as that property does not exist.
See 404 on https://developer.mozilla.org/en-US/docs/Web/CSS/border-shadow

Test Plan

Paste phui-oi-list-view.css into https://jigsaw.w3.org/css-validator/; find no CSS docs for that property.

Diff Detail

Repository
rP Phorge
Branch
cssBorderShadow (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1807
Build 1807: arc lint + arc unit

Event Timeline

aklapper created this revision.Tue, Mar 25, 09:56
Owners added a reviewer: O1: Blessed Committers.Tue, Mar 25, 09:56
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Mar 25, 09:56

Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:

./bin/celerity map

⚙️ Thanks! Bip bop I'm a bot - helping for T15209

aklapper requested review of this revision.Tue, Mar 25, 09:56
Harbormaster completed remote builds in B1805: Diff 2777.Tue, Mar 25, 09:56
valerio.bozzolan accepted this revision.Tue, Mar 25, 11:18

sgtm

This revision is now accepted and ready to land.Tue, Mar 25, 11:18
aklapper updated this revision to Diff 2780.Tue, Mar 25, 11:37

git rebase master

Harbormaster completed remote builds in B1807: Diff 2780.Tue, Mar 25, 11:37
Closed by commit rPa8c2bce6fe98: Remove invalid CSS border-shadow property for input.jx-tokenizer-input. · Explain WhyTue, Mar 25, 11:37
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPa8c2bce6fe98: Remove invalid CSS border-shadow property for input.jx-tokenizer-input.
aklapper mentioned this in Next Up.Tue, Mar 25, 11:38

Revision Contents
Changeset List

PathSizePackages
resources/
celerity/
O1: Blessed Committers
webroot/
rsrc/
css/
aphront/
1 lineO1: Blessed Committers

Diff 2780

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/aphront/tokenizer.css

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0