Page MenuHomePhorge
Differential D25923

Fix invalid CSS transition value for .jx-scrollbar-handle
ClosedPublic
Actions

Authored by aklapper on Mon, Mar 24, 17:56.
Tags
None
Referenced Files
F3339368: D25923.1743618672.diff
Tue, Apr 1, 18:31
F3337907: D25923.1743595414.diff
Tue, Apr 1, 12:03
F3336453: D25923.1743575106.diff
Tue, Apr 1, 06:25
F3333532: D25923.1743536594.diff
Mon, Mar 31, 19:43
F3320285: D25923.1743327191.diff
Sat, Mar 29, 09:33
F3318462: D25923.1743284860.diff
Fri, Mar 28, 21:47
F3317708: D25923.1743265567.diff
Fri, Mar 28, 16:26
F3317478: D25923.1743263182.diff
Fri, Mar 28, 15:46
View All 10 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rPfcd6a4c28aba: Fix invalid CSS transition value for .jx-scrollbar-handle
Summary

The W3C CSS validator throws 0 is not a transition value : opacity 0 linear.
0 is not a valid value; likely 0s were meant as in other existing CSS definitions.
See https://developer.mozilla.org/en-US/docs/Web/CSS/transition

Test Plan

Paste standard-page-view.css into https://jigsaw.w3.org/css-validator/ and read some CSS docs.

Diff Detail

Repository
rP Phorge
Branch
cssTransitionSec (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1803
Build 1803: arc lint + arc unit

Event Timeline

aklapper created this revision.Mon, Mar 24, 17:56
Owners added a reviewer: O1: Blessed Committers.Mon, Mar 24, 17:56
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMon, Mar 24, 17:56

Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:

./bin/celerity map

⚙️ Thanks! Bip bop I'm a bot - helping for T15209

aklapper requested review of this revision.Mon, Mar 24, 17:56
Harbormaster completed remote builds in B1803: Diff 2772.Mon, Mar 24, 17:56
valerio.bozzolan accepted this revision.Tue, Mar 25, 07:55

Makes sense thaanks, 0s seems also the documented default

This revision is now accepted and ready to land.Tue, Mar 25, 07:55
aklapper updated this revision to Diff 2774.Tue, Mar 25, 09:28

git rebase master

Harbormaster completed remote builds in B1804: Diff 2774.Tue, Mar 25, 09:28
Closed by commit rPfcd6a4c28aba: Fix invalid CSS transition value for .jx-scrollbar-handle. · Explain WhyTue, Mar 25, 09:29
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPfcd6a4c28aba: Fix invalid CSS transition value for .jx-scrollbar-handle.
aklapper mentioned this in Next Up.Tue, Mar 25, 09:41

Revision Contents
Changeset List

PathSizePackages
resources/
celerity/
O1: Blessed Committers
webroot/
rsrc/
css/
application/
base/
8 linesO1: Blessed Committers

Diff 2772

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0