- .phui-timeline-preview-header has never been used since introduction in rPdb66cd830d1b.
- Only use of .phui-timeline-change-details was removed in direct followup rP4e8e035de006.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rP367de18e7902: Remove orphan CSS rules from phui-timeline-view.css
Grep the code.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- cssBorderTypo (branched from master)
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1797 Build 1797: arc lint + arc unit
Event Timeline
Comment Actions
Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:
./bin/celerity map
⚙️ Thanks! Bip bop I'm a bot - helping for T15209
Comment Actions
Good news: we can be even more aggressive about that broken CSS rule, since it seems orphan.
Nothing in the source code seems to call it:
$ grep -R 'phui-timeline-preview' src/ resources/ support/ webroot/ webroot/rsrc/css/phui/phui-timeline-view.css:.phui-timeline-preview-header {
And only one commit introduces a line about it, and it's only the CSS definition:
$ git log -G 'phui-timeline-preview' commit db66cd830d1be431424d9ce147381e02a08c5727
So, introduced only here, orphan since it's creation in 2014:
rPdb66cd830d1b: PHUITimelineView
→ LET'S DROP phui-timeline-preview-header
Anyway the proposed change seems like reviving a dead horse, since the supposed syntax should be:
border: {width} {style} {color};But the syntax A/B is (still) this:
border: {style} {color} {width};Anyway I assume that the original intention was set top+bottom = 1px, and left+right = 0 but it cannot work like that. Anyway, who cares, we will never know. Let's drop that.
