There's already a "description" field on these, which I think was supposed to be displayed; We might have lost it at some point, which is concerning.
Use pht() for all human-visible text, to allow translation.

In D25898#24165, @avivey wrote:

There's already a "description" field on these, which I think was supposed to be displayed; We might have lost it at some point, which is concerning.

~~Right. T15526~~

Edited: no. need a task

valerio.bozzolan mentioned this in T15526: Diffusion: Description and tags are not shown.Thu, Feb 27, 17:39

Refactored to use the setControlInstructions method on the control

Harbormaster completed remote builds in B1754: Diff 2707.Fri, Feb 28, 17:51

I found a method called setControlInstructions that adds helpful text above the field

I am not sure if this layout is 100% better, but this is an option as well

Add new Repo

Edit existing Repo

Ekubischta edited the summary of this revision. (Show Details)Fri, Feb 28, 17:52

Ekubischta edited the summary of this revision. (Show Details)

Ekubischta edited the test plan for this revision. (Show Details)

setControlInstructions() is the right approach, after looking at other usage of it.
Tested the patch locally and works as expected.
I'd probably rephrase to "Callsign is the monogram rXXXX for this repository. It cannot contain spaces." and "Short Name is part of the URI paths for this repository. It cannot contain spaces." (we don't seem to use "repo" but only "repository" across the codebase, and use full stops), and drop the Placeholders (to have all helpful info in a single line), and rename the patch to "Show descriptions for "Callsign" and "Short Name" Repository form fields" (or such).
Apart from all that my nitpicking, good to go. Thanks for the patch!

close enough for my taste; Just add . at the end of each sentence.

Also, I think that visually, the instructions are too close to the next field and too far from their own field, but that's far out-of-scope for this one.

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php
292	add `.` and call this good

In D25898#24255, @avivey wrote:

Also, I think that visually, the instructions are too close to the next field and too far from their own field, but that's far out-of-scope for this one.

@avivey - I am looking at the EditEngine to see if there is a way to align to fields side by side?

That might visually help this form if the Call Sign and Short Name were side by side instead of on top of each other. Then the control instructions will align better.

Currently the control instructions visually are weird in this case because it seems like they belong to the item above it

Another option is to add instructions to both the name and description field to make them consistent

Updates after review to wording and dropped the placeholders

Harbormaster completed remote builds in B1765: Diff 2724.Wed, Mar 5, 14:28

Ekubischta edited the summary of this revision. (Show Details)Wed, Mar 5, 14:29

Ekubischta edited the test plan for this revision. (Show Details)

Ekubischta marked an inline comment as done.

Looks good to me. Feel free to land. Thanks for the patch!

This revision is now accepted and ready to land.Sun, Mar 9, 14:01

aklapper retitled this revision from Added helpful placeholders to the Create Repository form fields for Callsign and Short Name to Add instructions to Create Repository form fields for Callsign and Short Name.Sun, Mar 9, 14:02

Ekubischta mentioned this in Z1: Phorge.Mon, Mar 10, 13:23

Closed by commit rP5bd99a394aed: Add instructions to Create Repository form fields for Callsign and Short Name. · Explain WhyTue, Mar 11, 13:12

This revision was automatically updated to reflect the committed changes.

Ekubischta added a commit: rP5bd99a394aed: Add instructions to Create Repository form fields for Callsign and Short Name.