Page MenuHomePhorge
Differential D25813

Fix implicitly nullable parameter declarations for PHP 8.4
ClosedPublic
Actions

Authored by aklapper on Aug 30 2024, 14:37.
Tags
None
Referenced Files
F2983727: D25813.1739998534.diff
Tue, Feb 18, 20:55
F2977226: D25813.1739625220.diff
Fri, Feb 14, 13:13
F2977225: D25813.1739625219.diff
Fri, Feb 14, 13:13
F2977200: D25813.1739621401.diff
Fri, Feb 14, 12:10
F2977194: D25813.1739620540.diff
Fri, Feb 14, 11:55
F2918329: D25813.1737525245.diff
Jan 21 2025, 05:54
F2915382: D25813.1737470244.diff
Jan 20 2025, 14:37
F2889521: D25813.1737202641.diff
Jan 17 2025, 12:17
View All 15 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
chris
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated
Commits
rARC99e57a702164: Fix implicitly nullable parameter declarations for PHP 8.4
Summary

Implicitly nullable parameter declarations are deprecated in PHP 8.4:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

The proposed syntax was introduced in PHP 7.1.

Refs T15935

Test Plan

Try to successfully run ./bin/storage upgrade with PHP 8.4

Diff Detail

Repository
rARC Arcanist
Branch
T15935php84
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1574
Build 1574: arc lint + arc unit

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
utils/
2 lines59%
Loading...
O1: Blessed Committers

Diff 2437

View Options

src/utils/utils.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0