Page MenuHomePhorge
Differential D25813

Fix implicitly nullable parameter declarations for PHP 8.4
ClosedPublic
Actions

Authored by aklapper on Aug 30 2024, 14:37.
Tags
None
Referenced Files
F2918329: D25813.1737525245.diff
Tue, Jan 21, 05:54
F2915382: D25813.1737470244.diff
Mon, Jan 20, 14:37
F2889521: D25813.1737202641.diff
Fri, Jan 17, 12:17
F2874973: D25813.1736968257.diff
Tue, Jan 14, 19:10
F2874972: D25813.1736968257.diff
Tue, Jan 14, 19:10
F2874839: D25813.1736964689.diff
Tue, Jan 14, 18:11
F2874777: D25813.1736962370.diff
Tue, Jan 14, 17:32
F2873254: D25813.1736914361.diff
Tue, Jan 14, 04:12
View All 10 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
chris
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated
Commits
rARC99e57a702164: Fix implicitly nullable parameter declarations for PHP 8.4
Summary

Implicitly nullable parameter declarations are deprecated in PHP 8.4:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

The proposed syntax was introduced in PHP 7.1.

Refs T15935

Test Plan

Try to successfully run ./bin/storage upgrade with PHP 8.4

Diff Detail

Repository
rARC Arcanist
Branch
T15935php84
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1574
Build 1574: arc lint + arc unit

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
utils/
2 lines59%
Loading...
O1: Blessed Committers

Diff 2437

View Options

src/utils/utils.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0