Page MenuHomePhorge
Differential D25813

Fix implicitly nullable parameter declarations for PHP 8.4
ClosedPublic
Actions

Authored by aklapper on Aug 30 2024, 14:37.
Tags
None
Referenced Files
F3353115: D25813.1743825002.diff
Fri, Apr 4, 03:50
F3341611: D25813.1743654700.diff
Wed, Apr 2, 04:31
F3323593: D25813.1743386796.diff
Sun, Mar 30, 02:06
F3319306: D25813.1743303713.diff
Sat, Mar 29, 03:01
F3319299: D25813.1743303684.diff
Sat, Mar 29, 03:01
F3319290: D25813.1743303652.diff
Sat, Mar 29, 03:00
F3319284: D25813.1743303645.diff
Sat, Mar 29, 03:00
F3318837: D25813.1743291435.diff
Fri, Mar 28, 23:37
View All 34 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
chris
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated
Commits
rARC99e57a702164: Fix implicitly nullable parameter declarations for PHP 8.4
Summary

Implicitly nullable parameter declarations are deprecated in PHP 8.4:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

The proposed syntax was introduced in PHP 7.1.

Refs T15935

Test Plan

Try to successfully run ./bin/storage upgrade with PHP 8.4

Diff Detail

Repository
rARC Arcanist
Branch
T15935php84
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1574
Build 1574: arc lint + arc unit

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
utils/
2 lines59%
Loading...
O1: Blessed Committers

Diff 2437

View Options

src/utils/utils.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0